🐛 fix close_old_findings field in several parsers #14640

Author: manuel-sommer

dojo/tools/hydra/parser.py

@@ -74,7 +74,6 @@ def __extract_finding(
         ):
             msg = "Vital information is missing for this finding! Skipping this finding!"
             raise ValueError(msg)
-
         finding = Finding(
             test=test,
             title="Weak username / password combination found for " + host,
@@ -91,7 +90,7 @@ def __extract_finding(
             + password,
             static_finding=False,
             dynamic_finding=True,
-            service=metadata.service_type,
+            component_name=metadata.service_type,
         )
         if settings.V3_FEATURE_LOCATIONS:
             finding.unsaved_locations = [LocationData.url(host=host, port=port)]

unittests/tools/test_hydra_parser.py

@@ -128,6 +128,7 @@ def __assertFindingEquals(
                          actual_finding.description)
         self.assertFalse(actual_finding.static_finding)
         self.assertTrue(actual_finding.dynamic_finding)
+        self.assertEqual(actual_finding.component_name, "http-post-form")
         # The following fields should be not be set from this parser.
         self.assertIsNone(actual_finding.unique_id_from_tool)
         self.assertEqual(self.get_unsaved_locations(actual_finding)[0].host, finding_url)