🚨fix: Lint errors

Author: mfyll

dojo/tools/openreports/parser.py

@@ -74,23 +74,23 @@ def get_findings(self, scan_file, test):
 
     def _parse_report(self, test, report):
         findings = []
-        
+
         # Extract metadata
         metadata = report.get("metadata", {})
         report_name = metadata.get("name", "")
         namespace = metadata.get("namespace", "")
-        
+
         # Extract scope information
         scope = report.get("scope", {})
         scope_kind = scope.get("kind", "")
         scope_name = scope.get("name", "")
-        
+
         # Create service identifier from scope and metadata
         service_name = f"{namespace}/{scope_kind}/{scope_name}" if namespace else f"{scope_kind}/{scope_name}"
-        
+
         # Extract results
         results = report.get("results", [])
-        
+
         for result in results:
             if not isinstance(result, dict):
                 continue
@@ -110,23 +110,20 @@ def _create_finding_from_result(self, test, result, service_name, report_name):
             result_status = result.get("result", "")
             severity = result.get("severity", "info").lower()
             source = result.get("source", "")
-            
+
             # Extract properties
             properties = result.get("properties", {})
             pkg_name = properties.get("pkgName", "")
             installed_version = properties.get("installedVersion", "")
             fixed_version = properties.get("fixedVersion", "")
             primary_url = properties.get("primaryURL", "")
-            
+
             # Convert severity to DefectDojo format
             severity_normalized = OPENREPORTS_SEVERITIES.get(severity, "Info")
-            
+
             # Create title
-            if policy.startswith("CVE-"):
-                title = f"{policy} in {pkg_name}"
-            else:
-                title = f"{policy}: {message}"
-            
+            title = f"{policy} in {pkg_name}" if policy.startswith("CVE-") else f"{policy}: {message}"
+
             # Create description
             description = DESCRIPTION_TEMPLATE.format(
                 message=message,
@@ -139,25 +136,24 @@ def _create_finding_from_result(self, test, result, service_name, report_name):
                 fixed_version=fixed_version,
                 primary_url=primary_url,
             )
-            
+
             # Determine if fix is available
             fix_available = bool(fixed_version and fixed_version.strip())
-            
+
             # Set mitigation based on fixed version
             mitigation = f"Upgrade to version: {fixed_version}" if fixed_version else ""
-            
+
             # Set references
-            references = primary_url if primary_url else ""
-            
+            references = primary_url or ""
+
             # Determine active status based on result
-            active = result_status not in ["skip", "pass"]
-            verified = result_status in ["fail", "warn"]
-            
+            active = result_status not in {"skip", "pass"}
+            verified = result_status in {"fail", "warn"}
+
             # Create tags
             tags = [category, source]
             if scope_kind := service_name.split("/")[1] if "/" in service_name else "":
                 tags.append(scope_kind)
-            
             finding = Finding(
                 test=test,
                 title=title,
@@ -175,13 +171,13 @@ def _create_finding_from_result(self, test, result, service_name, report_name):
                 fix_available=fix_available,
                 tags=tags,
             )
-            
+
             # Add vulnerability ID if it's a CVE
             if policy.startswith("CVE-"):
                 finding.unsaved_vulnerability_ids = [policy]
-            
-            return finding
-            
+            else:
+                return finding
+
         except KeyError as exc:
             logger.warning("Failed to parse OpenReports result due to missing key: %r", exc)
             return None

unittests/tools/test_openreports_parser.py

@@ -20,7 +20,7 @@ def test_single_report(self):
             parser = OpenreportsParser()
             findings = parser.get_findings(test_file, Test())
             self.assertEqual(len(findings), 2)
-            
+
             # Test first finding (warn/low severity)
             finding1 = findings[0]
             self.assertEqual("CVE-2025-9232 in libcrypto3", finding1.title)
@@ -59,13 +59,13 @@ def test_list_format(self):
             parser = OpenreportsParser()
             findings = parser.get_findings(test_file, Test())
             self.assertEqual(len(findings), 2)
-            
+
             # Verify findings from different reports have different services
             services = {finding.service for finding in findings}
             self.assertEqual(len(services), 2)
             self.assertIn("test/Deployment/app1", services)
             self.assertIn("test/Deployment/app2", services)
-            
+
             # Verify CVE IDs
             cve_ids = [finding.unsaved_vulnerability_ids[0] for finding in findings]
             self.assertIn("CVE-2025-9232", cve_ids)
@@ -75,9 +75,9 @@ def test_parser_metadata(self):
         parser = OpenreportsParser()
         scan_types = parser.get_scan_types()
         self.assertEqual(["OpenReports Scan"], scan_types)
-        
+
         label = parser.get_label_for_scan_types("OpenReports Scan")
         self.assertEqual("OpenReports Scan", label)
-        
+
         description = parser.get_description_for_scan_types("OpenReports Scan")
-        self.assertEqual("Import OpenReports JSON scan report.", description)
+        self.assertEqual("Import OpenReports JSON scan report.", description)