Skip to content

Commit a13d1f8

Browse files
Maffoochclaude
andcommitted
test(vuln-id): re-baseline importer perf query counts for dual-write
The unconditional dual-write of VulnerabilityId entities + FindingVulnerabilityReference rows adds a small constant per-import query delta (batched, not per-finding). Counts updated to match a pure-OSS CI run: dedup first_import +6 / second_import +4; reimport import1 +6 / reimport1 +12 / reimport2 +5, across TestDojoImporterPerformanceSmall and ...SmallLocations. Async-task counts unchanged (dual-write is synchronous). reimport3 (queries4) unaffected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent f56f0f0 commit a13d1f8

1 file changed

Lines changed: 28 additions & 28 deletions

File tree

unittests/test_importers_performance.py

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -343,11 +343,11 @@ def test_import_reimport_reimport_performance_pghistory_async(self):
343343
configure_pghistory_triggers()
344344

345345
self._import_reimport_performance(
346-
expected_num_queries1=157,
346+
expected_num_queries1=163,
347347
expected_num_async_tasks1=2,
348-
expected_num_queries2=124,
348+
expected_num_queries2=136,
349349
expected_num_async_tasks2=1,
350-
expected_num_queries3=30,
350+
expected_num_queries3=35,
351351
expected_num_async_tasks3=1,
352352
expected_num_queries4=106,
353353
expected_num_async_tasks4=0,
@@ -367,11 +367,11 @@ def test_import_reimport_reimport_performance_pghistory_no_async(self):
367367
testuser.usercontactinfo.save()
368368

369369
self._import_reimport_performance(
370-
expected_num_queries1=176,
370+
expected_num_queries1=182,
371371
expected_num_async_tasks1=2,
372-
expected_num_queries2=134,
372+
expected_num_queries2=146,
373373
expected_num_async_tasks2=1,
374-
expected_num_queries3=40,
374+
expected_num_queries3=45,
375375
expected_num_async_tasks3=1,
376376
expected_num_queries4=106,
377377
expected_num_async_tasks4=0,
@@ -392,11 +392,11 @@ def test_import_reimport_reimport_performance_pghistory_no_async_with_product_gr
392392
self.system_settings(enable_product_grade=True)
393393

394394
self._import_reimport_performance(
395-
expected_num_queries1=186,
395+
expected_num_queries1=192,
396396
expected_num_async_tasks1=5,
397-
expected_num_queries2=144,
397+
expected_num_queries2=156,
398398
expected_num_async_tasks2=4,
399-
expected_num_queries3=49,
399+
expected_num_queries3=54,
400400
expected_num_async_tasks3=3,
401401
expected_num_queries4=115,
402402
expected_num_async_tasks4=3,
@@ -526,9 +526,9 @@ def test_deduplication_performance_pghistory_async(self):
526526
self.system_settings(enable_deduplication=True)
527527

528528
self._deduplication_performance(
529-
expected_num_queries1=93,
529+
expected_num_queries1=99,
530530
expected_num_async_tasks1=2,
531-
expected_num_queries2=73,
531+
expected_num_queries2=77,
532532
expected_num_async_tasks2=2,
533533
check_duplicates=False, # Async mode - deduplication happens later
534534
)
@@ -547,9 +547,9 @@ def test_deduplication_performance_pghistory_no_async(self):
547547
testuser.usercontactinfo.save()
548548

549549
self._deduplication_performance(
550-
expected_num_queries1=112,
550+
expected_num_queries1=118,
551551
expected_num_async_tasks1=2,
552-
expected_num_queries2=93,
552+
expected_num_queries2=97,
553553
expected_num_async_tasks2=2,
554554
)
555555

@@ -580,9 +580,9 @@ def test_deduplication_performance_pghistory_async_wait(self):
580580
# returns instantly without executing dedup on the request's DB connection.
581581
with patch("celery.result.AsyncResult.get", return_value=None):
582582
self._deduplication_performance(
583-
expected_num_queries1=94,
583+
expected_num_queries1=100,
584584
expected_num_async_tasks1=2,
585-
expected_num_queries2=74,
585+
expected_num_queries2=78,
586586
expected_num_async_tasks2=2,
587587
dedup_mode="async_wait",
588588
check_duplicates=False,
@@ -670,11 +670,11 @@ def test_import_reimport_reimport_performance_pghistory_async(self):
670670
configure_pghistory_triggers()
671671

672672
self._import_reimport_performance(
673-
expected_num_queries1=164,
673+
expected_num_queries1=170,
674674
expected_num_async_tasks1=2,
675-
expected_num_queries2=133,
675+
expected_num_queries2=145,
676676
expected_num_async_tasks2=1,
677-
expected_num_queries3=38,
677+
expected_num_queries3=43,
678678
expected_num_async_tasks3=1,
679679
expected_num_queries4=107,
680680
expected_num_async_tasks4=0,
@@ -694,11 +694,11 @@ def test_import_reimport_reimport_performance_pghistory_no_async(self):
694694
testuser.usercontactinfo.save()
695695

696696
self._import_reimport_performance(
697-
expected_num_queries1=185,
697+
expected_num_queries1=191,
698698
expected_num_async_tasks1=2,
699-
expected_num_queries2=145,
699+
expected_num_queries2=157,
700700
expected_num_async_tasks2=1,
701-
expected_num_queries3=50,
701+
expected_num_queries3=55,
702702
expected_num_async_tasks3=1,
703703
expected_num_queries4=107,
704704
expected_num_async_tasks4=0,
@@ -719,11 +719,11 @@ def test_import_reimport_reimport_performance_pghistory_no_async_with_product_gr
719719
self.system_settings(enable_product_grade=True)
720720

721721
self._import_reimport_performance(
722-
expected_num_queries1=198,
722+
expected_num_queries1=204,
723723
expected_num_async_tasks1=5,
724-
expected_num_queries2=158,
724+
expected_num_queries2=170,
725725
expected_num_async_tasks2=4,
726-
expected_num_queries3=59,
726+
expected_num_queries3=64,
727727
expected_num_async_tasks3=3,
728728
expected_num_queries4=119,
729729
expected_num_async_tasks4=3,
@@ -826,9 +826,9 @@ def test_deduplication_performance_pghistory_async(self):
826826
self.system_settings(enable_deduplication=True)
827827

828828
self._deduplication_performance(
829-
expected_num_queries1=100,
829+
expected_num_queries1=106,
830830
expected_num_async_tasks1=2,
831-
expected_num_queries2=76,
831+
expected_num_queries2=80,
832832
expected_num_async_tasks2=2,
833833
check_duplicates=False, # Async mode - deduplication happens later
834834
)
@@ -846,8 +846,8 @@ def test_deduplication_performance_pghistory_no_async(self):
846846
testuser.usercontactinfo.save()
847847

848848
self._deduplication_performance(
849-
expected_num_queries1=121,
849+
expected_num_queries1=127,
850850
expected_num_async_tasks1=2,
851-
expected_num_queries2=204,
851+
expected_num_queries2=208,
852852
expected_num_async_tasks2=2,
853853
)

0 commit comments

Comments
 (0)