test(vuln-id): make setUpTestData valid under full model validation

The rest-framework CI matrix runs a V3_FEATURE_LOCATIONS=True leg where base save()
calls full_clean(). The new vuln-id test classes created Product/Test without the
required description / scan_type / environment, so all 7 setUpClass hooks errored with
ValidationError under that leg (they passed the False leg). Provide the required fields
(Finding creation already skips validation via skip_validation=True, so it's unaffected).
Reproduced locally with V3_FEATURE_LOCATIONS=True: 14 tests green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: Maffooch

unittests/test_migrations.py

@@ -8,6 +8,7 @@
 
 from dojo.finding.vulnerability_id import resolve_vulnerability_id_type
 from dojo.models import (
+    Development_Environment,
     Engagement,
     Finding,
     FindingVulnerabilityReference,
@@ -198,12 +199,17 @@ class TestVulnerabilityIdBackfill(TestCase):
     def setUpTestData(cls):
         now = timezone.now()
         prod_type = Product_Type.objects.create(name="vulnid-pt")
-        product = Product.objects.create(prod_type=prod_type, name="vulnid-prod")
+        # description / scan_type / environment are required under full model validation
+        # (base save full_clean when V3_FEATURE_LOCATIONS is on — the CI "(true)" matrix leg).
+        product = Product.objects.create(prod_type=prod_type, name="vulnid-prod", description="vuln-id backfill test")
         engagement = Engagement.objects.create(product=product, target_start=now, target_end=now)
         test_type = Test_Type.objects.create(name="vulnid-tt")
+        environment = Development_Environment.objects.get_or_create(name="Development")[0]
         test = Test.objects.create(
             engagement=engagement,
             test_type=test_type,
+            scan_type="vulnid-tt",
+            environment=environment,
             target_start=now,
             target_end=now,
         )

unittests/test_vulnerability_id.py

@@ -15,6 +15,7 @@
 from dojo.finding.api.serializer import VulnerabilityIdsField
 from dojo.finding.helper import save_vulnerability_ids
 from dojo.models import (
+    Development_Environment,
     Engagement,
     Finding,
     FindingVulnerabilityReference,
@@ -36,11 +37,17 @@ class VulnerabilityIdDualWriteTestCase(TestCase):
     @classmethod
     def setUpTestData(cls):
         cls.prod_type = Product_Type.objects.create(name="vulnid-dw-pt")
-        cls.product = Product.objects.create(prod_type=cls.prod_type, name="vulnid-dw-prod")
+        # description / scan_type / environment are required under full model validation
+        # (base save full_clean when V3_FEATURE_LOCATIONS is on — the CI "(true)" matrix leg).
+        cls.product = Product.objects.create(
+            prod_type=cls.prod_type, name="vulnid-dw-prod", description="vuln-id dual-write tests",
+        )
         cls.engagement = Engagement.objects.create(product=cls.product, target_start=now(), target_end=now())
         cls.test_type = Test_Type.objects.create(name="vulnid-dw-tt")
+        cls.environment = Development_Environment.objects.get_or_create(name="Development")[0]
         cls.test = Test.objects.create(
-            engagement=cls.engagement, test_type=cls.test_type, target_start=now(), target_end=now(),
+            engagement=cls.engagement, test_type=cls.test_type, scan_type="vulnid-dw-tt",
+            environment=cls.environment, target_start=now(), target_end=now(),
         )
         cls.user = get_user_model().objects.create(username="vulnid-dw-user")