fix: resolve ruff lint violations in helper and tests

Author: valentijnscholten

dojo/finding/helper.py

@@ -616,7 +616,8 @@ def reconfigure_duplicate_cluster(original, cluster_outside):
 
 
 def prepare_duplicates_for_delete(obj):
-    """Prepare duplicate clusters before deleting a Test, Engagement, Product, or Product_Type.
+    """
+    Prepare duplicate clusters before deleting a Test, Engagement, Product, or Product_Type.
 
     Resets inside-scope duplicate FKs and reconfigures outside-scope clusters
     so that cascade_delete won't hit FK violations on the self-referential
@@ -664,7 +665,7 @@ def prepare_duplicates_for_delete(obj):
         .iterator(chunk_size=500)
     )
 
-    for chunk_ids in batched(originals_ids, 500):
+    for chunk_ids in batched(originals_ids, 500, strict=False):
         for original in Finding.objects.filter(id__in=chunk_ids).prefetch_related("original_finding"):
             # Inside-scope duplicates were already unlinked by the bulk UPDATE above,
             # so original_finding.all() now only contains outside-scope duplicates.

unittests/test_prepare_duplicates_for_delete.py

@@ -225,7 +225,8 @@ def test_mixed_inside_and_outside_duplicates(self):
 
     @override_settings(DUPLICATE_CLUSTER_CASCADE_DELETE=True)
     def test_cascade_delete_skips_outside_reconfigure(self):
-        """When DUPLICATE_CLUSTER_CASCADE_DELETE=True, outside duplicates are left untouched.
+        """
+        When DUPLICATE_CLUSTER_CASCADE_DELETE=True, outside duplicates are left untouched.
 
         The caller (async_delete_crawl_task) handles deletion of outside-scope
         duplicates separately via bulk_delete_findings.
@@ -300,7 +301,8 @@ def test_found_by_copied_to_new_original(self):
         self.assertIn(test_type_2.id, found_by_ids)
 
     def test_delete_finding_reconfigures_cross_engagement_duplicate(self):
-        """Deleting an original finding makes its cross-engagement duplicate standalone.
+        """
+        Deleting an original finding makes its cross-engagement duplicate standalone.
 
         Setup: product with eng A (finding A, original) and eng B (finding B, duplicate of A).
         Action: delete finding A.
@@ -331,13 +333,14 @@ def test_delete_finding_reconfigures_cross_engagement_duplicate(self):
         self.assertFalse(finding_b.is_mitigated)
 
     def test_delete_product_with_cross_engagement_duplicates(self):
-        """Deleting a product with cross-engagement duplicates succeeds without FK violations.
+        """
+        Deleting a product with cross-engagement duplicates succeeds without FK violations.
 
         Setup: product with eng A (finding A, original) and eng B (finding B, duplicate of A).
         Action: delete the entire product via async_delete_crawl_task.
         Expected: product and all findings are deleted without errors.
         """
-        from dojo.utils import async_delete_crawl_task
+        from dojo.utils import async_delete_crawl_task  # noqa: PLC0415
 
         finding_a = self._create_finding(self.test1, "Original A")
         finding_a.active = True