Skip to content

Commit c5009d9

Browse files
authored
Fix service field overwrite issue #13461
1 parent cba7d81 commit c5009d9

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

dojo/importers/default_importer.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ def process_findings(
204204
# scan_date was provided, override value from parser
205205
if self.scan_date_override:
206206
unsaved_finding.date = self.scan_date.date()
207-
if self.service is not None:
207+
if self.service is not None and self.service != "":
208208
unsaved_finding.service = self.service
209209

210210
# Force parsers to use unsaved_tags (stored in below after saving)
@@ -343,7 +343,7 @@ def close_old_findings(
343343
else:
344344
old_findings = old_findings.filter(test__engagement=self.test.engagement)
345345
# Use the service to differentiate further
346-
if self.service is not None:
346+
if self.service is not None and self.service != "":
347347
old_findings = old_findings.filter(service=self.service)
348348
else:
349349
old_findings = old_findings.filter(Q(service__isnull=True) | Q(service__exact=""))

0 commit comments

Comments
 (0)