perf: add bulk_delete_findings, fix CASCADE_DELETE and scope expansion

- Add bulk_delete_findings() wrapper: M2M cleanup + chunked cascade_delete
- reconfigure_duplicate_cluster: return early when CASCADE_DELETE=True
  instead of calling Django .delete() which fires signals per finding
- finding_delete: use bulk_delete_findings when CASCADE_DELETE=True
- async_delete_crawl_task: expand scope to include outside-scope duplicates,
  use bulk_delete_findings instead of manual M2M + cascade_delete calls
- Fix test to use async_delete class instead of direct task import

Author: valentijnscholten

dojo/finding/helper.py

@@ -751,7 +751,7 @@ def bulk_clear_finding_m2m(finding_qs):
 
 def bulk_delete_findings(finding_qs, chunk_size=1000):
     """
-    Delete findings and all related objects efficiently.
+    Delete findings and all related objects efficiently. Including any related object in Dojo-Pro
 
     Sends the pre_bulk_delete signal, clears M2M through tables (not
     discovered by _meta.related_objects), then uses cascade_delete for

dojo/utils.py

@@ -2047,7 +2047,7 @@ def _get_object_name(obj):
 
 
 @app.task
-def async_delete_crawl_task(obj, **kwargs):
+def async_delete_task(obj, **kwargs):
     """
     Delete an object and all its related objects using the SQL cascade walker.
 
@@ -2064,6 +2064,12 @@ def async_delete_crawl_task(obj, **kwargs):
     )
     from dojo.utils_cascade_delete import cascade_delete  # noqa: PLC0415 circular import
 
+    logger.debug("ASYNC_DELETE: Deleting %s: %s", _get_object_name(obj), obj)
+    if not isinstance(obj, ASYNC_DELETE_SUPPORTED_TYPES):
+        logger.debug("ASYNC_DELETE: %s async delete not supported. Deleting normally: %s", _get_object_name(obj), obj)
+        obj.delete()
+        return
+
     obj_name = _get_object_name(obj)
     logger.info("ASYNC_DELETE: Starting deletion of %s: %s", obj_name, obj)
 
@@ -2116,24 +2122,6 @@ def async_delete_crawl_task(obj, **kwargs):
     logger.info("ASYNC_DELETE: Successfully deleted %s: %s", obj_name, obj)
 
 
-@app.task
-def async_delete_task(obj, **kwargs):
-    """
-    Module-level Celery task to delete an object and its related objects.
-
-    Accepts **kwargs for _pgh_context injected by dojo_dispatch_task.
-    Uses PgHistoryTask base class (default) to preserve pghistory context for audit trail.
-    """
-    from dojo.celery_dispatch import dojo_dispatch_task  # noqa: PLC0415 circular import
-
-    logger.debug("ASYNC_DELETE: Deleting %s: %s", _get_object_name(obj), obj)
-    if isinstance(obj, ASYNC_DELETE_SUPPORTED_TYPES):
-        dojo_dispatch_task(async_delete_crawl_task, obj)
-    else:
-        logger.debug("ASYNC_DELETE: %s async delete not supported. Deleting normally: %s", _get_object_name(obj), obj)
-        obj.delete()
-
-
 class async_delete:
 
     """

dojo/utils_cascade_delete.py

@@ -61,6 +61,8 @@ def cascade_delete(from_model, instance_pk_query, skip_relations=None, base_mode
     recurses into CASCADE children first (bottom-up), then deletes at the
     current level. No query execution until recursion unwinds.
 
+    Includes any related object in Dojo-Pro
+
     Args:
         from_model: The model class to delete from.
         instance_pk_query: QuerySet selecting the records to delete.

unittests/test_prepare_duplicates_for_delete.py

@@ -340,7 +340,7 @@ def test_delete_product_with_cross_engagement_duplicates(self):
         Action: delete the entire product via async_delete_crawl_task.
         Expected: product and all findings are deleted without errors.
         """
-        from dojo.utils import async_delete_crawl_task  # noqa: PLC0415
+        from dojo.utils import async_delete  # noqa: PLC0415
 
         finding_a = self._create_finding(self.test1, "Original A")
         finding_a.active = True
@@ -355,7 +355,8 @@ def test_delete_product_with_cross_engagement_duplicates(self):
         finding_b_id = finding_b.id
 
         with impersonate(self.testuser):
-            async_delete_crawl_task(self.product)
+            async_del = async_delete()
+            async_del.delete(self.product)
 
         # Everything should be gone
         self.assertFalse(Product.objects.filter(id=product_id).exists())