Skip to content

Commit d23cf1d

Browse files
committed
add documentation to parsing logic; cleanup short names
1 parent 811b19d commit d23cf1d

2 files changed

Lines changed: 386 additions & 208 deletions

File tree

dojo/tools/reversinglabs_spectraassure/parser.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,12 @@
1111

1212
SCAN_TYPE = "ReversingLabs Spectra Assure"
1313

14+
"""
15+
The actual parsing is done by `RlJsonInfo` and it stores data as a collection of `CveInfoNode`
16+
A `CveInfoNode` matches a dd.Finding more closely and makes the collection of Findings easy.
17+
18+
"""
19+
1420

1521
class ReversinglabsSpectraassureParser:
1622

@@ -87,15 +93,15 @@ def get_findings(
8793
test: Any,
8894
) -> list[Finding]:
8995
# ------------------------------------
90-
rji = RlJsonInfo(file_handle=file)
91-
rji.get_cve_active_all()
96+
rl_json_info_instance = RlJsonInfo(file_handle=file)
97+
rl_json_info_instance.get_cve_active_all()
9298

9399
self._findings: list[Finding] = []
94100
self._duplicates: dict[str, Finding] = {}
95101

96-
for cin in rji.get_results_list():
102+
for cve_info_node_instance in rl_json_info_instance.get_results_list():
97103
finding = self._one_finding(
98-
node=cin,
104+
node=cve_info_node_instance,
99105
test=test,
100106
)
101107
if finding is None:

0 commit comments

Comments
 (0)