Skip to content

Commit efe2b2c

Browse files
committed
update
1 parent ec67f25 commit efe2b2c

6 files changed

Lines changed: 16 additions & 10 deletions

File tree

dojo/tools/openreports/parser.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919

2020
DESCRIPTION_TEMPLATE = """{message}
2121
22+
**Service:** {service}
2223
**Category:** {category}
2324
**Policy:** {policy}
2425
**Result:** {result}
@@ -218,6 +219,7 @@ def _create_finding_from_result(self, test, result, service_name, report_name, r
218219
# Create description
219220
description = DESCRIPTION_TEMPLATE.format(
220221
message=message,
222+
service=service_name,
221223
category=category,
222224
policy=policy,
223225
result=result_status,
@@ -250,7 +252,6 @@ def _create_finding_from_result(self, test, result, service_name, report_name, r
250252
mitigation=mitigation,
251253
component_name=pkg_name,
252254
component_version=installed_version,
253-
service=service_name,
254255
active=active,
255256
verified=verified,
256257
static_finding=True,

dojo/tools/orca_security/csv_parser.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@ def parse(self, content):
8484
severity_justification=build_severity_justification(orca_score_raw),
8585
static_finding=True, # CSPM scan data is static analysis
8686
dynamic_finding=False,
87-
service=source or None, # Source identifies the cloud resource/service
8887
component_name=inventory_name or None, # Inventory is the specific resource
8988
date=parse_date(created_at),
9089
)

dojo/tools/orca_security/json_parser.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,6 @@ def parse(self, content):
8989
severity_justification=build_severity_justification(orca_score),
9090
static_finding=True, # CSPM scan data is static analysis
9191
dynamic_finding=False,
92-
service=source or None, # Source identifies the cloud resource/service
9392
component_name=inventory_name or None, # Inventory is the specific resource
9493
date=parse_date(created_at),
9594
)

unittests/tools/test_jfrog_xray_api_summary_artifact_parser.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ def test_parse_file_with_one_vuln(self):
3333
self.assertEqual(" code.", item.description[-6:])
3434
self.assertIsNone(item.mitigation)
3535
self.assertEqual("artifact1", item.component_name)
36+
self.assertIsNone(item.service)
3637
self.assertIsNotNone(item.tags)
3738
self.assertEqual("1.0", item.component_version)
3839
self.assertEqual("artifact_path/artifact1/1.0/", item.file_path[:28])

unittests/tools/test_openreports_parser.py

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ def test_single_report(self):
2828
self.assertEqual("3.5.2-r1", finding1.component_version)
2929
self.assertEqual("Upgrade to version: 3.5.4-r0", finding1.mitigation)
3030
self.assertEqual("https://avd.aquasec.com/nvd/cve-2025-9232", finding1.references)
31-
self.assertEqual("test/Deployment/test-app", finding1.service)
31+
self.assertIsNone(finding1.service)
32+
self.assertIn("**Service:** test/Deployment/test-app", finding1.description)
3233
self.assertTrue(finding1.active)
3334
self.assertTrue(finding1.verified)
3435
self.assertTrue(finding1.fix_available)
@@ -47,7 +48,8 @@ def test_single_report(self):
4748
self.assertEqual("v1.24.4", finding2.component_version)
4849
self.assertEqual("Upgrade to version: 1.23.12, 1.24.6", finding2.mitigation)
4950
self.assertEqual("https://avd.aquasec.com/nvd/cve-2025-47907", finding2.references)
50-
self.assertEqual("test/Deployment/test-app", finding2.service)
51+
self.assertIsNone(finding2.service)
52+
self.assertIn("**Service:** test/Deployment/test-app", finding2.description)
5153
self.assertTrue(finding2.active)
5254
self.assertTrue(finding2.verified)
5355
self.assertTrue(finding2.fix_available)
@@ -63,7 +65,8 @@ def test_single_report(self):
6365
self.assertEqual("N/A", finding3.component_version)
6466
self.assertEqual("Upgrade to version: Configure proper security headers", finding3.mitigation)
6567
self.assertEqual("https://www.cisecurity.org/benchmark/docker", finding3.references)
66-
self.assertEqual("test/Deployment/test-app", finding3.service)
68+
self.assertIsNone(finding3.service)
69+
self.assertIn("**Service:** test/Deployment/test-app", finding3.description)
6770
self.assertTrue(finding3.active)
6871
self.assertTrue(finding3.verified)
6972
self.assertTrue(finding3.fix_available)
@@ -80,8 +83,11 @@ def test_list_format(self):
8083
findings = parser.get_findings(test_file, Test())
8184
self.assertEqual(len(findings), 3)
8285

83-
# Verify findings from different reports have different services
84-
services = {finding.service for finding in findings}
86+
# Verify findings from different reports have different service contexts in descriptions
87+
services = {
88+
finding.description.split("**Service:** ")[1].split("\n", 1)[0]
89+
for finding in findings if "**Service:** " in finding.description
90+
}
8591
self.assertEqual(len(services), 2)
8692
self.assertIn("test/Deployment/app1", services)
8793
self.assertIn("test/Deployment/app2", services)

unittests/tools/test_orca_security_parser.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def test_parse_csv_one_finding(self):
2525
self.assertTrue(finding.static_finding)
2626
self.assertFalse(finding.dynamic_finding)
2727
self.assertEqual("TestRole_abc123", finding.component_name)
28-
self.assertEqual("TestRole_abc123", finding.service)
28+
self.assertIsNone(finding.service)
2929
self.assertEqual("OrcaScore: 5.1", finding.severity_justification)
3030
self.assertIn("IAM misconfigurations", finding.description)
3131
self.assertEqual(["CSPM", "source: Orca Scan"], finding.unsaved_tags)
@@ -69,7 +69,7 @@ def test_parse_json_one_finding(self):
6969
self.assertTrue(finding.static_finding)
7070
self.assertFalse(finding.dynamic_finding)
7171
self.assertEqual("TestRole_abc123", finding.component_name)
72-
self.assertEqual("TestRole_abc123", finding.service)
72+
self.assertIsNone(finding.service)
7373
self.assertEqual("OrcaScore: 5.1", finding.severity_justification)
7474
self.assertIn("IAM misconfigurations", finding.description)
7575
self.assertEqual(["CSPM", "source: Orca Scan"], finding.unsaved_tags)

0 commit comments

Comments
 (0)