Skip to content

Checkmarx one doc update#12408

Merged
Maffooch merged 2 commits into
DefectDojo:devfrom
skywalke34:checkmarx-one-doc-update
May 22, 2025
Merged

Checkmarx one doc update#12408
Maffooch merged 2 commits into
DefectDojo:devfrom
skywalke34:checkmarx-one-doc-update

Conversation

@skywalke34

@skywalke34 skywalke34 commented May 7, 2025

Copy link
Copy Markdown
Contributor

Description
Checkmarx one documentation update

Test results
no tests

Documentation
Documentation update only.

Significantly updating the Checkmarx One parser documentation including mapping table, details of different types of scans, and special data handling.
@github-actions github-actions Bot added settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR docs ui helm lint labels May 7, 2025
@skywalke34 skywalke34 changed the base branch from master to dev May 7, 2025 22:49
@skywalke34 skywalke34 marked this pull request as ready for review May 8, 2025 00:17
@dryrunsecurity

dryrunsecurity Bot commented May 8, 2025

Copy link
Copy Markdown

DryRun Security

No security concerns detected in this pull request.


All finding details can be found in the DryRun Security Dashboard.

@valentijnscholten valentijnscholten left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be very helpful to document which fields are parsed and how. Could eventually become part of the "how to write a parser" guide?

One thing I am wondering about is the line numbers. These could potentially change slightly on small changes or non-functional changes like linting or refactorings. Does it bring a lot of value to put these line numbers in the docs? My initial thoughts that when people use "CTRL+F" on the parser file they'll quickly find the section for a specific field?

@Maffooch Maffooch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment from Val is spot on

One thing I am wondering about is the line numbers. These could potentially change slightly on small changes or non-functional changes like linting or refactorings. Does it bring a lot of value to put these line numbers in the docs? My initial thoughts that when people use "CTRL+F" on the parser file they'll quickly find the section for a specific field?

I wouldn't consider this a blocker, but something to by mindful about in the future

@skywalke34

skywalke34 commented May 9, 2025

Copy link
Copy Markdown
Contributor Author

I think it can be very helpful to document which fields are parsed and how. Could eventually become part of the "how to write a parser" guide?

One thing I am wondering about is the line numbers. These could potentially change slightly on small changes or non-functional changes like linting or refactorings. Does it bring a lot of value to put these line numbers in the docs? My initial thoughts that when people use "CTRL+F" on the parser file they'll quickly find the section for a specific field?

I too have questioned and am uncertain of the value of including line numbers vs trying to identify the function, and agree your thoughts are completely valid. The reason I decided to go ahead and try to include line numbers - even if a single function from lines X to Y have all the parsing logic or line numbers are changed from linting, etc - is for future analysis by an AI LLM. I am learning there is a wide range of approaches each individual parser can take to process similar finding fields into the same finding data field. My thinking is if the documentation contains enough detail about which data fields are being parsed, including line numbers in the parser.py code, it should be possible to perform AI analysis comparing all the parsers, the fields they parse, and how they are parsing them - which may help us come up with a more standardized approach to coach parser developers how to parse specific fields, best practices, etc. I could just be taking it "too far"! :) ¯_(ツ)_/¯

@Maffooch Maffooch added this to the 2.47.0 milestone May 9, 2025
Removed references to line numbers within the parser.py.
@github-actions github-actions Bot removed settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR ui helm lint labels May 13, 2025
@skywalke34

Copy link
Copy Markdown
Contributor Author

Carefully removed references to line numbers.

@Maffooch Maffooch requested a review from hblankenship May 13, 2025 14:57

@mtesauro mtesauro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch Maffooch merged commit c4daf99 into DefectDojo:dev May 22, 2025
78 checks passed
@skywalke34 skywalke34 deleted the checkmarx-one-doc-update branch May 14, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants