Skip to content

docs: Add non-parser Test Types to product hierarchy documentation#12419

Merged
Maffooch merged 1 commit into
DefectDojo:devfrom
skywalke34:doc-test-type-update
May 15, 2025
Merged

docs: Add non-parser Test Types to product hierarchy documentation#12419
Maffooch merged 1 commit into
DefectDojo:devfrom
skywalke34:doc-test-type-update

Conversation

@skywalke34

Copy link
Copy Markdown
Contributor

Add detailed explanation of the two categories of Test Types in DefectDojo:

  • Parser-based Test Types that work with imported scanner output files
  • Non-parser Test Types for manual findings creation. Currently, API Test, Static Check, Pen Test, Web Application Test, Security Research, Threat Modeling, Manual Code Review are non-parser test types.

Clarify that non-parser Test Types appear in the "Scan Type" dropdown when creating a new test but not when importing scans, helping users understand when to use each type.

Add detailed explanation of the two categories of Test Types in DefectDojo:
- Parser-based Test Types that work with imported scanner output files
- Non-parser Test Types for manual findings creation (API Test, Static Check, Pen Test, Web Application Test, Security Research, Threat Modeling, Manual Code Review)

Clarify that non-parser Test Types appear in the "Scan Type" dropdown when creating a new test but not when importing scans, helping users understand when to use each type.RetryClaude can make mistakes. Please double-check responses.
@github-actions github-actions Bot added the docs label May 8, 2025
@paulOsinski

Copy link
Copy Markdown
Contributor

Approved ^ @skywalke34 you can merge this with bugfix if you like and it'll be released to our docs site more quickly

@skywalke34 skywalke34 changed the base branch from dev to bugfix May 9, 2025 13:43
@skywalke34 skywalke34 marked this pull request as ready for review May 9, 2025 13:44
@dryrunsecurity

dryrunsecurity Bot commented May 9, 2025

Copy link
Copy Markdown

DryRun Security

🔴 Risk threshold exceeded.

This pull request contains sensitive edits to critical files like context_processors.py and base.html, with multiple potential security risks including session timing vulnerabilities, broad exception handling, and client-side session management issues that could expose sensitive information or allow manipulation of session mechanisms.

⚠️ Configured Codepaths Edit in dojo/context_processors.py
Vulnerability Configured Codepaths Edit
Description Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml.
⚠️ Configured Codepaths Edit in dojo/templates/base.html
Vulnerability Configured Codepaths Edit
Description Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml.
💭 Unconfirmed Findings (8)
Vulnerability Potential Dependency Version Pinning Risk
Description Pinning to specific commit hashes in .github/workflows/release-x-manual-helm-chart.yml can introduce risks if the referenced commit contains unverified or malicious changes
Vulnerability Potential Unverified Dependency Updates
Description Dependency updates in docs/package-lock.json, docs/package.json, and requirements.txt without thorough testing can introduce unknown security risks
Vulnerability Session Timing Side-Channel Information Leak
Description In dojo/context_processors.py, session timing information is exposed which could potentially be used to infer user session details
Vulnerability Broad Exception Handling
Description In dojo/context_processors.py, a catch-all exception handler silently returns an empty dictionary, potentially masking runtime errors
Vulnerability Potential Information Disclosure via Session Expiry Notification
Description Session expiry warning mechanism in dojo/settings/settings.dist.py might inadvertently expose sensitive information about session management
Vulnerability Configurable Session Warning Interval Risks
Description Configurable session warning interval in dojo/settings/settings.dist.py could potentially be manipulated to probe session management mechanisms
Vulnerability Client-Side Session Timing Exposure
Description Session timeout logic in dojo/templates/base.html is implemented entirely client-side using JavaScript, which could potentially be manipulated
Vulnerability Lack of Server-Side Session Validation
Description No corresponding server-side validation in dojo/templates/base.html to enforce session timeout, potentially giving users a false sense of security

We've notified @mtesauro.


All finding details can be found in the DryRun Security Dashboard.

@Maffooch

Maffooch commented May 9, 2025

Copy link
Copy Markdown
Contributor

@skywalke34 this one might have to go into the dev branch since it was started from the dev branch. Other options is to create a new PR based from the bugfix branch

@Maffooch Maffooch added this to the 2.47.0 milestone May 9, 2025
@Maffooch Maffooch changed the base branch from bugfix to dev May 9, 2025 15:35
@Maffooch Maffooch requested review from dogboat and hblankenship May 12, 2025 17:59
@paulOsinski

Copy link
Copy Markdown
Contributor

@Maffooch @skywalke34 my mistake!

@mtesauro mtesauro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch Maffooch merged commit 241015a into DefectDojo:dev May 15, 2025
76 of 77 checks passed
@skywalke34 skywalke34 deleted the doc-test-type-update branch May 14, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants