excel export: enhance handling of finding groups, better logging#12435
Merged
Maffooch merged 2 commits intoMay 15, 2025
Merged
Conversation
|
This pull request introduces potential logging risks, including a debug log that might expose sensitive finding information and a reduction in error logging severity that could obscure important processing issues. 💭 Unconfirmed Findings (2)
All finding details can be found in the DryRun Security Dashboard. |
Maffooch
approved these changes
May 12, 2025
valentijnscholten
force-pushed
the
excel-export-error-logging
branch
from
26dbdf6 to
1ec7a06
Compare
valentijnscholten
changed the title
Maffooch
approved these changes
May 13, 2025
hblankenship
approved these changes
May 13, 2025
dogboat
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance logging for errors during Excel exports. Or rather they are warnings, so we log them at
warninglevel from now on.Inspired by #11911
Added later: Some more testing lead me to what I believe is a copy-and-paste error where
get_foreign_keys()was not called.So the PR now also fixes the conversion problem and outputs finding group values correctly:
fixes #10012