Skip to content

UI Pagination: Reduce the options to more reasonable numbers#12439

Merged
mtesauro merged 1 commit into
bugfixfrom
page-size-reduction
May 15, 2025
Merged

UI Pagination: Reduce the options to more reasonable numbers#12439
mtesauro merged 1 commit into
bugfixfrom
page-size-reduction

Conversation

@Maffooch

Copy link
Copy Markdown
Contributor

In most web applications, the dropdown options for page size rarely exceed 50, but DefectDojo had an option for 500, and even "All" results. When working in an instance with many users, fetching all results in a single page could cause slower response times for other users using the application at the same time. To accommodate, the highest page in the drop down will be 250

Note: This change does not enforce a page size limit of any kind, but simply removes the advertisement of the larger page sizes

[sc-11117]

@Maffooch Maffooch added this to the 2.46.3 milestone May 13, 2025
@Maffooch Maffooch requested a review from mtesauro as a code owner May 13, 2025 19:46
@github-actions github-actions Bot added the ui label May 13, 2025
@dryrunsecurity

Copy link
Copy Markdown

DryRun Security

This pull request addresses a potential performance risk by limiting the maximum page size to 250 in the pagination template to prevent memory exhaustion and improve system performance when handling large datasets.

💭 Unconfirmed Findings (1)
Vulnerability Potential Performance Risk in Large Dataset Pagination
Description Located in dojo/templates/dojo/paging_snippet.html, this change limits the maximum page size to 250 to prevent performance issues and memory exhaustion when handling large result sets. The modification removes the 'All items' option and adjusts page size dropdown options to improve system performance.

All finding details can be found in the DryRun Security Dashboard.

@mtesauro mtesauro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro mtesauro merged commit bc62293 into bugfix May 15, 2025
78 checks passed
@Maffooch Maffooch deleted the page-size-reduction branch October 21, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants