UI Pagination: Reduce the options to more reasonable numbers#12439
Merged
Conversation
|
This pull request addresses a potential performance risk by limiting the maximum page size to 250 in the pagination template to prevent memory exhaustion and improve system performance when handling large datasets. 💭 Unconfirmed Findings (1)
All finding details can be found in the DryRun Security Dashboard. |
hblankenship
approved these changes
May 14, 2025
dogboat
approved these changes
May 15, 2025
valentijnscholten
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In most web applications, the dropdown options for page size rarely exceed 50, but DefectDojo had an option for 500, and even "All" results. When working in an instance with many users, fetching all results in a single page could cause slower response times for other users using the application at the same time. To accommodate, the highest page in the drop down will be 250
Note: This change does not enforce a page size limit of any kind, but simply removes the advertisement of the larger page sizes
[sc-11117]