defender: fix no vulnerabilities check#12448
Merged
mtesauro merged 1 commit intoMay 15, 2025
Merged
Conversation
|
This pull request contains a low-confidence finding related to potential information disclosure through verbose logging in the MS Defender parser, which could inadvertently reveal internal system details that might assist an attacker in reconnaissance efforts. 💭 Unconfirmed Findings (1)
All finding details can be found in the DryRun Security Dashboard. |
Member
Author
|
@manuel-sommer Could you review if with this PR the code still achieves the goal of your earlier PR? |
Maffooch
approved these changes
May 14, 2025
hblankenship
approved these changes
May 14, 2025
dogboat
approved these changes
May 14, 2025
manuel-sommer
approved these changes
May 15, 2025
manuel-sommer
left a comment
manuel-sommer
left a comment
Contributor
There was a problem hiding this comment.
thank you for the ping, works as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check to bail out early expects a
vulnerabilities/folder entry to always be present in the zip file if there are files in that folder. We've seen that this is not always the case as some zips do not contain entries for folders, only entries for actual files.This PR changes the "bail out check" to work well in both scenario's.
Raised by user on Slack: https://owasp.slack.com/archives/C2P5BA8MN/p1747126211915059