Skip to content

defender: fix no vulnerabilities check #12448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtesauro merged 1 commit into from
May 15, 2025
Merged

defender: fix no vulnerabilities check #12448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions dojo/tools/ms_defender/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,16 +34,20 @@ def get_findings(self, file, test):
input_zip = zipfile.ZipFile(file.name, "r")
else:
input_zip = zipfile.ZipFile(file, "r")

zipdata = {name: input_zip.read(name) for name in input_zip.namelist()}
if zipdata.get("vulnerabilities/") is None:
return []
vulnerabilityfiles = []
machinefiles = []
for content in list(zipdata):
if "vulnerabilities/" in content and content != "vulnerabilities/":
vulnerabilityfiles.append(content)
if "machines/" in content and content != "machines/":
machinefiles.append(content)

if len(vulnerabilityfiles) == 0:
logger.debug("No vulnerabilities.json files found in the vulnerabilities/ folder")
return []

vulnerabilities = []
machines = {}
for vulnerabilityfile in vulnerabilityfiles:
Expand Down