Skip to content

legacy reimport: make matching on title case-insensitive #12487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valentijnscholten merged 2 commits into from
May 22, 2025
Merged

legacy reimport: make matching on title case-insensitive #12487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ef5219
legacy reimport: match title case insensitive
valentijnscholten May 20, 2025
a7b450a
update reimporter
valentijnscholten May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dojo/importers/default_reimporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ def match_new_finding_to_existing_finding(
# If you have use cases going through this section, you're advised to create a deduplication configuration for your parser
logger.warning("Legacy reimport. In case of issue, you're advised to create a deduplication configuration in order not to go through this section")
return Finding.objects.filter(
title=unsaved_finding.title,
title__iexact=unsaved_finding.title,
test=self.test,
severity=unsaved_finding.severity,
numerical_severity=Finding.get_numerical_severity(unsaved_finding.severity)).order_by("id")
Expand Down
2 changes: 1 addition & 1 deletion dojo/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ def match_finding_to_existing_findings(finding, product=None, engagement=None, t
return (
Finding.objects.filter(
**custom_filter,
title=finding.title,
title__iexact=finding.title,
severity=finding.severity,
numerical_severity=Finding.get_numerical_severity(finding.severity),
).order_by("id")
Expand Down