Skip to content

remove google sheets leftovers#12509

Merged
Maffooch merged 1 commit into
DefectDojo:devfrom
valentijnscholten:google-sheets-cleanup
May 29, 2025
Merged

remove google sheets leftovers#12509
Maffooch merged 1 commit into
DefectDojo:devfrom
valentijnscholten:google-sheets-cleanup

Conversation

@valentijnscholten

Copy link
Copy Markdown
Member

Remove some leftovers from the Google Sheets feature that was removed in 2.21.0

@valentijnscholten valentijnscholten added this to the 2.47.0 milestone May 26, 2025
@valentijnscholten valentijnscholten changed the base branch from bugfix to dev May 26, 2025 18:50
@valentijnscholten valentijnscholten changed the title Google sheets cleanup remove google sheets leftovers May 26, 2025
@dryrunsecurity

dryrunsecurity Bot commented May 26, 2025

Copy link
Copy Markdown

DryRun Security

This pull request appears to involve potential risks related to permission management and Google Sheets integration, including the removal of code that could impact system access control, existing integrations, and testing workflows.

💭 Unconfirmed Findings (3)
Vulnerability Potential Incomplete Permission Management
Description Risk found in dojo/management/commands/initialize_permissions.py where removing permission creation code may impact system access control mechanisms, potentially creating unintended access control gaps.
Vulnerability Potential Unintended Feature Removal
Description Risk identified in dojo/user/utils.py involving deletion of Google Sheets permissions configuration code, which might break existing integrations and permission settings.
Vulnerability Removal of Google Sheets Configuration Navigation Method
Description Risk in tests/base_test_class.py where elimination of method for accessing Google Sheets configuration could impact testing and user workflows.

All finding details can be found in the DryRun Security Dashboard.

@mtesauro mtesauro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch Maffooch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit - not blocking

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this whole file could be deleted now

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I wasn't sure if I should remove it or leave it in place for if we need it in the future

@Maffooch Maffooch requested review from dogboat and hblankenship May 28, 2025 23:30
@Maffooch Maffooch requested a review from blakeaowens May 29, 2025 20:34
@Maffooch Maffooch merged commit 9d99c62 into DefectDojo:dev May 29, 2025
145 of 146 checks passed
xansec pushed a commit to xansec/django-DefectDojo that referenced this pull request Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants