Skip to content

post processing: check for finding being None #12713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maffooch merged 1 commit into from
Jun 30, 2025
Merged

post processing: check for finding being None #12713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dojo/decorators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def __wrapper__(*args, **kwargs):
try:
instance = model.objects.get(id=model_or_id)
except model.DoesNotExist:
logger.debug("error instantiating model_or_id: %s for model: %s: DoesNotExist", model_or_id, model)
logger.warning("error instantiating model_or_id: %s for model: %s: DoesNotExist", model_or_id, model)
instance = None
args = list(args)
args[parameter] = instance
Expand Down
4 changes: 4 additions & 0 deletions dojo/finding/helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,10 @@ def add_findings_to_auto_group(name, findings, group_by, *, create_finding_group
def post_process_finding_save(finding, dedupe_option=True, rules_option=True, product_grading_option=True, # noqa: FBT002
issue_updater_option=True, push_to_jira=False, user=None, *args, **kwargs): # noqa: FBT002 - this is bit hard to fix nice have this universally fixed

if not finding:
logger.warning("post_process_finding_save called with finding==None, skipping post processing")
return

system_settings = System_Settings.objects.get()

# STEP 1 run all status changing tasks sequentially to avoid race conditions
Expand Down