unittests: import query/task count capture#12716
Merged
valentijnscholten merged 11 commits intoJul 3, 2025
Merged
Conversation
3228588 to
845cc9f
Compare
766d08b to
ebfcaa7
Compare
f895256 to
ccaddf9
Compare
|
This pull request contains a security scan results file that could potentially expose sensitive vulnerability information if not properly secured, though the current risk is considered passing and non-blocking.
Security Scan Report Exposure in
|
| Vulnerability | Security Scan Report Exposure |
|---|---|
| Description | The JSON files containing security scan results could potentially expose sensitive information about the application's vulnerabilities if not properly secured. These files should be treated as confidential and not included in publicly accessible repositories or deployment artifacts. |
All finding details can be found in the DryRun Security Dashboard.
Maffooch
approved these changes
Jul 2, 2025
hblankenship
approved these changes
Jul 2, 2025
dogboat
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ads a unit test for import/reimport that captures the number of queries executed and the number of dojo async tasks created/generated.
By capturing this we help ourselves in the future when PRs affected the number of queries. Sometimes this is intended and OK. Sometimes it means there's an unforeseen side effect that lowers performance.
I have some performance related PRs coming up and it will be nice to see the numbers go down.
I choose the StackHawk parser because its samples have multiple endpoints per finding making it a good case to also cover the endpoint part of the import/reimport process.