Consistent "Close old findings" between UI and API#12774
Merged
Conversation
🔴 Risk threshold exceeded.This pull request contains a sensitive edit to the file "dojo/forms.py" which requires configuration in the
🔴 Configured Codepaths Edit in
|
| Vulnerability | Configured Codepaths Edit |
|---|---|
| Description | Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml. |
We've notified @mtesauro.
All finding details can be found in the DryRun Security Dashboard.
1f52cb2 to
8627254
Compare
Maffooch
approved these changes
Jul 11, 2025
valentijnscholten
approved these changes
Jul 14, 2025
blakeaowens
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If we look at the import scan result screen in the UI:
If we look at the API description for the same fields:
I found this confusing the first time I saw and it made me check the code to make sure they were setting the same fields (and they are).
This PR tries to put them in sync, by rephrasing the ones in the UI (as those seem the furthest from the actual variable intent).
I think it could be done the other way around or even switching the field to choices field (
Do not close,Close at engagement level,Close at product level) but those would impact API consumers...Checklist
This checklist is for your information.
dev.dev.bugfixbranch.