ms_defender: skip empty files from zip#12780
Merged
mtesauro merged 1 commit intoJul 18, 2025
Merged
Conversation
|
No security concerns detected in this pull request. All finding details can be found in the DryRun Security Dashboard. |
Maffooch
approved these changes
Jul 16, 2025
blakeaowens
approved these changes
Jul 16, 2025
dogboat
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12767
Not sure if this was really a bug, but it seems like different zip file creators create different types of zip.
This time it seems that the zip contains some additional empty files with the same name as the folder that holds the true/real files.
This PR skips those and ass some more error handling for future non-default scenario's.