Skip to content

performance do_not_reactivate: adding a note doesn't need a finding save #12901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtesauro merged 1 commit into from
Aug 9, 2025
Merged

performance do_not_reactivate: adding a note doesn't need a finding save #12901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions dojo/importers/default_reimporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ def process_matched_mitigated_finding(
"have different dates, not taking action"
)
logger.debug(msg)
# Return True here to force the loop to continue
# Return True here to force the loop to continue to the next finding
return existing_finding, True
# even if there is no mitigation time, skip it, because both the current finding and
# the reimported finding are is_mitigated
Expand All @@ -480,8 +480,7 @@ def process_matched_mitigated_finding(
)
note.save()
existing_finding.notes.add(note)
existing_finding.save_no_options()
# Return True here to force the loop to continue
# Return True here to force the loop to continue to the next finding
return existing_finding, True
logger.debug(
f"Reactivating: - {existing_finding.id}: {existing_finding.title} "
Expand Down