Default ordering to FindingGroup#13081
Conversation
🔴 Risk threshold exceeded.This pull request contains a sensitive edit to the file "dojo/finding_group/views.py" which requires careful review, though it is not automatically blocking and can be configured in the
🔴 Configured Codepaths Edit in
|
| Vulnerability | Configured Codepaths Edit |
|---|---|
| Description | Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml. |
We've notified @mtesauro.
All finding details can be found in the DryRun Security Dashboard.
|
What does this PR do? I think it fixes the ordering of findings in finding groups if a non-default ordering is selected? |
|
The warning error that was being generated in the GroupFindings view basically occurs because I didn’t define a default ordering for the view when no specific ordering is selected. I’m just setting a default to avoid the warning. |
|
Is it similar to #13119 or are both PRs needed? |
|
I reviewed it and the idea seems similar to setting a default ordering, but the way the person is doing it looks wrong. If someone selects to order by a field, for example |
|
Can you rebase your PR and remove their change so we can merge your fix? |
|
I created a new PR to the |
|
Yes |
As discussed in #13001