Skip to content

user mentioning: diplay author instead of recipient#13332

Merged
valentijnscholten merged 1 commit intoDefectDojo:devfrom
valentijnscholten:user-mention-fix
Oct 8, 2025
Merged

user mentioning: diplay author instead of recipient#13332
valentijnscholten merged 1 commit intoDefectDojo:devfrom
valentijnscholten:user-mention-fix

Conversation

@valentijnscholten
Copy link
Copy Markdown
Member

@valentijnscholten valentijnscholten commented Oct 5, 2025

Fixes #10104

When a user mentioned another user, the contents of the notification contained the recipient as the "author" of the mentioning.

Example for where admin mentioned user1: On top is the new correct content, on the bottom the old incorrect content.

Screenshot 2025-10-05 202459

Ideally we have a global/generic way of setting the author/actor on a notification. But for now this fixes at least the most obvious notification where the author is really needed.

@valentijnscholten valentijnscholten added this to the 2.52.0 milestone Oct 5, 2025
@github-actions github-actions Bot added the ui label Oct 5, 2025
Copy link
Copy Markdown
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch Maffooch requested review from Jino-T and blakeaowens October 7, 2025 14:59
@valentijnscholten valentijnscholten merged commit e3f9734 into DefectDojo:dev Oct 8, 2025
147 checks passed
Maffooch pushed a commit to valentijnscholten/django-DefectDojo that referenced this pull request Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants