engagement: allow unlinking of JIRA epic#13333
Merged
valentijnscholten merged 1 commit intoDefectDojo:devfrom Oct 8, 2025
Merged
engagement: allow unlinking of JIRA epic#13333valentijnscholten merged 1 commit intoDefectDojo:devfrom
valentijnscholten merged 1 commit intoDefectDojo:devfrom
Conversation
|
This pull request includes a broad except Exception: in dojo/engagement/views.py around unlink_jira that logs the full exception via logger.exception, which risks recording sensitive JIRA API request/response details or stack traces in internal logs; while it returns a generic 500 to users, the internal logging could expose sensitive information if logs are accessed. Consider narrowing the exception handling and avoiding logging sensitive response details (or sanitize/redact them) before writing to logs.
Broad Exception Handling with Sensitive Data Logging in
|
| Vulnerability | Broad Exception Handling with Sensitive Data Logging |
|---|---|
| Description | The unlink_jira function uses a broad except Exception: block when calling jira_helper.unlink_jira. Interactions with external APIs like JIRA can raise exceptions containing sensitive information (e.g., API request/response details, internal URLs, detailed JIRA error messages, or stack traces from the client library). While the generic HTTP 500 response prevents direct leakage to the user, the logger.exception call will log these potentially sensitive details internally. If an attacker gains access to these logs, they could exfiltrate sensitive information, which constitutes a security risk. |
django-DefectDojo/dojo/engagement/views.py
Lines 1153 to 1156 in d6cc3b2
All finding details can be found in the DryRun Security Dashboard.
Maffooch
approved these changes
Oct 7, 2025
Jino-T
approved these changes
Oct 7, 2025
blakeaowens
approved these changes
Oct 8, 2025
Maffooch
pushed a commit
to valentijnscholten/django-DefectDojo
that referenced
this pull request
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes you find a bug report or feature request that is a good match for an LLM.
This PR fixes #9071