Skip to content

auto_create_context: make engagement creation atomic #13444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maffooch merged 1 commit into from
Oct 17, 2025
Merged

auto_create_context: make engagement creation atomic #13444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions dojo/importers/auto_create_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,10 +318,16 @@ def get_or_create_engagement(
target_end = (timezone.now() + timedelta(days=365)).date()
# Create the engagement
with transaction.atomic():
return Engagement.objects.select_for_update().create(
# Lock the parent product row to serialize engagement creation per product
locked_product = Product.objects.select_for_update().get(pk=product.pk)
# Re-check for an existing engagement now that we hold the lock
existing = get_last_object_or_none(Engagement, product=locked_product, name=engagement_name)
if existing:
return existing
return Engagement.objects.create(
engagement_type="CI/CD",
name=engagement_name,
product=product,
product=locked_product,
lead=get_current_user(),
target_start=target_start,
target_end=target_end,
Expand Down