jira_integration: changes risk acceptance expiration date to a better default#13467
Closed
maxi-bee wants to merge 4 commits intoDefectDojo:bugfixfrom
Closed
jira_integration: changes risk acceptance expiration date to a better default#13467maxi-bee wants to merge 4 commits intoDefectDojo:bugfixfrom
maxi-bee wants to merge 4 commits intoDefectDojo:bugfixfrom
Conversation
… default - Currently the Jira integration sets the expiration time to `None` when configured, resulting on the risk acceptance coming from Jira (via configured resolution) never expire - This commit sets such expiration time to the setting "Risk Acceptance form default days" configured on "System Settings"
🔴 Risk threshold exceeded.This pull request modifies several sensitive codepaths (dojo/jira_link/helper.py, dojo/models.py, and dojo/db_migrations/0245_alter_jira_instance_accepted_mapping_resolution.py), with the scanner flagging these edits as sensitive and advising configuration of sensitive paths and allowed authors in .dryrunsecurity.yaml. The findings are marked at a failing risk threshold but not set to block the merge.
🔴 Configured Codepaths Edit in
|
| Vulnerability | Configured Codepaths Edit |
|---|---|
| Description | Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml. |
🔴 Configured Codepaths Edit in dojo/jira_link/helper.py
| Vulnerability | Configured Codepaths Edit |
|---|---|
| Description | Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml. |
🔴 Configured Codepaths Edit in dojo/models.py
| Vulnerability | Configured Codepaths Edit |
|---|---|
| Description | Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml. |
🔴 Configured Codepaths Edit in dojo/db_migrations/0245_alter_jira_instance_accepted_mapping_resolution.py
| Vulnerability | Configured Codepaths Edit |
|---|---|
| Description | Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml. |
We've notified @mtesauro.
All finding details can be found in the DryRun Security Dashboard.
Closed
3 tasks
- fixes space - adds missing library
- corrects the help text for the UI of the Jira Integration
Member
|
@maxi-bee Thanks for the PR. Could you look at creating a django migration? Unfortunately this is needed for Django, even though you only changed a help text. |
Closed
3 tasks
github-actions
Bot
added
the
New Migration
Contributor
Author
Alright went for a: using: and got this new migration file just commited |
Member
|
Would you be able to rebase against |
Contributor
Author
So @valentijnscholten do you mean to drop my changes into |
Contributor
Author
|
@valentijnscholten moved to #13488 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nonewhen configured, resulting on the risk acceptance coming from Jira (via configured resolution) never expire