Skip to content

jira_integration: changes risk acceptance expiration date to a better default#13488

Merged
valentijnscholten merged 3 commits intoDefectDojo:devfrom
maxi-bee:dev
Oct 23, 2025
Merged

jira_integration: changes risk acceptance expiration date to a better default#13488
valentijnscholten merged 3 commits intoDefectDojo:devfrom
maxi-bee:dev

Conversation

@maxi-bee
Copy link
Copy Markdown
Contributor

@maxi-bee maxi-bee commented Oct 21, 2025

Fixes #13439

@dryrunsecurity
Copy link
Copy Markdown

dryrunsecurity Bot commented Oct 21, 2025

DryRun Security

🔴 Risk threshold exceeded.

This pull request modifies sensitive files related to database migrations and Jira integration (dojo/db_migrations/0245_alter_jira_instance_accepted_mapping_resolution.py, dojo/jira_link/helper.py, and dojo/models.py), triggering configured codepath alerts; review these changes carefully against your .dryrunsecurity.yaml allowed paths/authors before merging.

🔴 Configured Codepaths Edit in dojo/jira_link/helper.py
Vulnerability Configured Codepaths Edit
Description Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml.
🔴 Configured Codepaths Edit in dojo/models.py
Vulnerability Configured Codepaths Edit
Description Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml.
🔴 Configured Codepaths Edit in dojo/db_migrations/0245_alter_jira_instance_accepted_mapping_resolution.py
Vulnerability Configured Codepaths Edit
Description Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml.

We've notified @mtesauro.


All finding details can be found in the DryRun Security Dashboard.

@maxi-bee
Copy link
Copy Markdown
Contributor Author

That linting rule looks like a suggestion than anything folks, applying the suggestion will make the rest of the similar code look odd. Other than that this looks good to me @valentijnscholten

Comment thread dojo/models.py Outdated
@valentijnscholten valentijnscholten added this to the 2.52.0 milestone Oct 21, 2025
Comment thread dojo/models.py Outdated
@valentijnscholten
Copy link
Copy Markdown
Member

That linting rule looks like a suggestion than anything folks, applying the suggestion will make the rest of the similar code look odd. Other than that this looks good to me @valentijnscholten

I made it pass the Ruff linter as that's a requirement.

@valentijnscholten valentijnscholten merged commit fd5b2fb into DefectDojo:dev Oct 23, 2025
151 checks passed
Maffooch pushed a commit to valentijnscholten/django-DefectDojo that referenced this pull request Feb 16, 2026
… default (DefectDojo#13488)

* jira_integration: changes risk acceptance expiration date to a better default

* Update dojo/models.py

* Update dojo/models.py

---------

Co-authored-by: valentijnscholten <valentijnscholten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Migration Adding a new migration file. Take care when merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Findings risk accepted using "Risk Accepted resolution mapping" have no expiration date

5 participants