Skip to content

fix(helm): Fix PVC templating after #13210 #13619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valentijnscholten merged 3 commits into from
Nov 7, 2025
Merged

fix(helm): Fix PVC templating after #13210 #13619

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1adfa9
fix(helm): Typo in description of digests
kiblik Nov 4, 2025
3da7506
fix(helm): Fix PVC templating after #13210
kiblik Nov 4, 2025
e3611ad
Merge branch 'helm_fix_sha' into helm_fix_pvc
kiblik Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion helm/defectdojo/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,6 @@ dependencies:
# description: Critical bug
annotations:
artifacthub.io/prerelease: "true"
artifacthub.io/changes: ""
artifacthub.io/changes: |
- kind: fixed
description: Broken rendering of media PVC
10 changes: 5 additions & 5 deletions helm/defectdojo/templates/media-pvc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
{{- with .Values.extraAnnotations }}
{{- with $.Values.extraAnnotations }}
annotations:
{{- range $key, $value := . }}
{{ $key }}: {{ quote $value }}
Expand All @@ -16,19 +16,19 @@ metadata:
app.kubernetes.io/instance: {{ $.Release.Name }}
app.kubernetes.io/managed-by: {{ $.Release.Service }}
helm.sh/chart: {{ include "defectdojo.chart" $ }}
{{- range $key, $value := .Values.extraLabels }}
{{- range $key, $value := $.Values.extraLabels }}
{{ $key }}: {{ quote $value }}
{{- end }}
name: {{ $fullName }}
namespace: {{ .Release.Namespace }}
namespace: {{ $.Release.Namespace }}
spec:
accessModes:
{{- toYaml .persistentVolumeClaim.accessModes | nindent 4 }}
resources:
requests:
storage: {{ .persistentVolumeClaim.size }}
{{- if .persistentVolumeClaim.storageClassName }}
storageClassName: {{ .persistentVolumeClaim.storageClassName }}
{{- with .persistentVolumeClaim.storageClassName }}
storageClassName: {{ . }}
{{- end }}
{{- end }}
{{- end }}