log a line when custom hash method is used#13679
Conversation
valentijnscholten
requested review from
Maffooch and
mtesauro
as code owners
🔴 Risk threshold exceeded.This pull request modifies a sensitive file (dojo/models.py), and the scanner detected sensitive edits; you can configure sensitive file paths and allowed authors in .dryrunsecurity.yaml. The finding is marked with a failing risk threshold but is not set to block the PR.
🔴 Configured Codepaths Edit in
|
| Vulnerability | Configured Codepaths Edit |
|---|---|
| Description | Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml. |
We've notified @mtesauro.
All finding details can be found in the DryRun Security Dashboard.
dogboat
left a comment
dogboat
left a comment
There was a problem hiding this comment.
Approved, one thought that can be safely ignored.
| def set_hash_code(self, dedupe_option): | ||
| from dojo.utils import get_custom_method # noqa: PLC0415 circular import | ||
| if hash_method := get_custom_method("FINDING_HASH_METHOD"): | ||
| deduplicationLogger.debug("Using custom hash method") |
There was a problem hiding this comment.
Since this is for debug, is there any value in including the method name (either from the given setting or by stringifying the resolved method)?
There was a problem hiding this comment.
@valentijnscholten Before I approve and merged this I wanted to give you a chance to comment here.
Co-authored-by: Valentijn Scholten <valentijn.scholten@iodigital.com>
6 participants
add some logging to make it explicit and clear when debugging hash code issues.