Release: Merge back 2.52.2 into dev from: master-into-dev/2.52.2-2.53.0-dev#13721
Release: Merge back 2.52.2 into dev from: master-into-dev/2.52.2-2.53.0-dev#13721
Conversation
….53.0-dev Release: Merge back 2.52.1 into bugfix from: master-into-bugfix/2.52.1-2.53.0-dev
Signed-off-by: kiblik <5609770+kiblik@users.noreply.github.com>
* 💄 beautify drheader jsonfiles * add more json
* 🎉 Advance ibm app parser with fix_available * fix
* 🎉 Advance Dawnscanner with fix_available * update
Signed-off-by: kiblik <5609770+kiblik@users.noreply.github.com>
Co-authored-by: Valentijn Scholten <valentijn.scholten@iodigital.com>
…ding, and Tests (#13696)
Co-authored-by: Paul Osinski <paul.m.osinski@gmail.com>
…or improved readability
feat(helm): Relocate docs/schema hints
Qualys parser add CVEs to Vulnerability Ids for xml files
Release: Merge release into master from: release/2.52.2
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
🔴 Risk threshold exceeded.This pull request modifies several sensitive codepaths (dojo/finding/views.py, dojo/finding/helper.py, dojo/api_v2/views.py) and also introduces or leaves in place notification code that directly includes engagement.name, finding.title, and test.title in messages (Slack, email, Teams, webhooks) without sanitization or truncation, risking information disclosure if those fields contain sensitive data. Reviewers should verify allowed authors for the changed files and ensure notification content is sanitized, truncated, or recipient checks are tightened.
🔴 Configured Codepaths Edit in
|
| Vulnerability | Configured Codepaths Edit |
|---|---|
| Description | Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml. |
🔴 Configured Codepaths Edit in dojo/finding/helper.py
| Vulnerability | Configured Codepaths Edit |
|---|---|
| Description | Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml. |
🔴 Configured Codepaths Edit in dojo/api_v2/views.py
| Vulnerability | Configured Codepaths Edit |
|---|---|
| Description | Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml. |
🔴 Configured Codepaths Edit in dojo/finding/helper.py
| Vulnerability | Configured Codepaths Edit |
|---|---|
| Description | Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml. |
🔴 Configured Codepaths Edit in dojo/finding/views.py
| Vulnerability | Configured Codepaths Edit |
|---|---|
| Description | Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml. |
Information Disclosure in dojo/api_v2/views.py
| Vulnerability | Information Disclosure |
|---|---|
| Description | The engagement.name is directly included in notification messages (e.g., Slack, Email, Webhooks, internal alerts) when a user is mentioned in a note. If the engagement.name contains sensitive information, and an authorized user mentions an unauthorized user in a note, this sensitive information could be disclosed to the unauthorized recipient via the notification system. While the note content itself is truncated, the engagement.name in the parent_title is not. |
django-DefectDojo/dojo/api_v2/views.py
Lines 540 to 543 in 6f0897a
Information Disclosure in dojo/api_v2/views.py
| Vulnerability | Information Disclosure |
|---|---|
| Description | The finding.title is used directly in notification messages sent to various channels (email, Slack, MS Teams, webhooks) without explicit sanitization or truncation. If a finding's title contains sensitive information (e.g., internal system names, specific vulnerability details that should not be widely broadcast), this information could be exposed to unauthorized recipients through these notification channels. While the system attempts to filter recipients based on permissions, the parent_title is used in the notification message itself, which could be problematic if the title is inherently sensitive and the notification goes to a broader audience than intended for the specific finding's details. |
django-DefectDojo/dojo/api_v2/views.py
Lines 1107 to 1110 in 6f0897a
Information Disclosure in dojo/api_v2/views.py
| Vulnerability | Information Disclosure |
|---|---|
| Description | The parent_title for notifications, which includes test.title, is directly incorporated into messages sent to various notification channels (Slack, MS Teams, Email, Webhooks, and internal Alerts). There is no explicit sanitization or truncation of test.title before it is used in these notifications. In a vulnerability management system like DefectDojo, test.title can contain sensitive information such as internal project names, specific vulnerability details, or references to unreleased features. This sensitive information could be disclosed to unauthorized users or external systems if notification channels are not strictly controlled. |
django-DefectDojo/dojo/api_v2/views.py
Lines 2165 to 2168 in 6f0897a
We've notified @mtesauro.
All finding details can be found in the DryRun Security Dashboard.
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
….52.2-2.53.0-dev Release: Merge back 2.52.2 into dev from: master-into-dev/2.52.2-2.53.0-dev
Release triggered by
rossops