Skip to content

Release: Merge back 2.52.2 into dev from: master-into-dev/2.52.2-2.53.0-dev#13721

Merged
rossops merged 30 commits intodevfrom
master-into-dev/2.52.2-2.53.0-dev
Nov 17, 2025
Merged

Release: Merge back 2.52.2 into dev from: master-into-dev/2.52.2-2.53.0-dev#13721
rossops merged 30 commits intodevfrom
master-into-dev/2.52.2-2.53.0-dev

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Release triggered by rossops

DefectDojo release bot and others added 29 commits November 10, 2025 17:24
….53.0-dev

Release: Merge back 2.52.1 into bugfix from: master-into-bugfix/2.52.1-2.53.0-dev
* 🐛 harden jfrog xray unified file parsing

* fix
Signed-off-by: kiblik <5609770+kiblik@users.noreply.github.com>
* 💄 beautify drheader jsonfiles

* add more json
* 🎉 Advance ibm app parser with fix_available

* fix
* 🎉 Advance Dawnscanner with fix_available

* update
* 🐛 fix debug mode in logging #13659

* update
* 🎉 implement new threatmapper file format

* update
Signed-off-by: kiblik <5609770+kiblik@users.noreply.github.com>
Co-authored-by: Valentijn Scholten <valentijn.scholten@iodigital.com>
* 🐛 fix finding closed with a provided mitigated date

* advance unittests
Co-authored-by: Paul Osinski <paul.m.osinski@gmail.com>
feat(helm): Relocate docs/schema hints
Qualys parser add CVEs to Vulnerability Ids for xml files
Release: Merge release into master from: release/2.52.2
@github-actions github-actions Bot requested a review from Maffooch as a code owner November 17, 2025 15:43
@github-actions
Copy link
Copy Markdown
Contributor Author

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@dryrunsecurity
Copy link
Copy Markdown

dryrunsecurity Bot commented Nov 17, 2025

DryRun Security

🔴 Risk threshold exceeded.

This pull request modifies several sensitive codepaths (dojo/finding/views.py, dojo/finding/helper.py, dojo/api_v2/views.py) and also introduces or leaves in place notification code that directly includes engagement.name, finding.title, and test.title in messages (Slack, email, Teams, webhooks) without sanitization or truncation, risking information disclosure if those fields contain sensitive data. Reviewers should verify allowed authors for the changed files and ensure notification content is sanitized, truncated, or recipient checks are tightened.

🔴 Configured Codepaths Edit in dojo/finding/views.py
Vulnerability Configured Codepaths Edit
Description Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml.
🔴 Configured Codepaths Edit in dojo/finding/helper.py
Vulnerability Configured Codepaths Edit
Description Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml.
🔴 Configured Codepaths Edit in dojo/api_v2/views.py
Vulnerability Configured Codepaths Edit
Description Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml.
🔴 Configured Codepaths Edit in dojo/finding/helper.py
Vulnerability Configured Codepaths Edit
Description Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml.
🔴 Configured Codepaths Edit in dojo/finding/views.py
Vulnerability Configured Codepaths Edit
Description Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml.
Information Disclosure in dojo/api_v2/views.py
Vulnerability Information Disclosure
Description The engagement.name is directly included in notification messages (e.g., Slack, Email, Webhooks, internal alerts) when a user is mentioned in a note. If the engagement.name contains sensitive information, and an authorized user mentions an unauthorized user in a note, this sensitive information could be disclosed to the unauthorized recipient via the notification system. While the note content itself is truncated, the engagement.name in the parent_title is not.

parent_title=f"Engagement: {engagement.name}",
)
serialized_note = serializers.NoteSerializer(

Information Disclosure in dojo/api_v2/views.py
Vulnerability Information Disclosure
Description The finding.title is used directly in notification messages sent to various channels (email, Slack, MS Teams, webhooks) without explicit sanitization or truncation. If a finding's title contains sensitive information (e.g., internal system names, specific vulnerability details that should not be widely broadcast), this information could be exposed to unauthorized recipients through these notification channels. While the system attempts to filter recipients based on permissions, the parent_title is used in the notification message itself, which could be problematic if the title is inherently sensitive and the notification goes to a broader audience than intended for the specific finding's details.

parent_title=f"Finding: {finding.title}",
)
if finding.has_jira_issue:

Information Disclosure in dojo/api_v2/views.py
Vulnerability Information Disclosure
Description The parent_title for notifications, which includes test.title, is directly incorporated into messages sent to various notification channels (Slack, MS Teams, Email, Webhooks, and internal Alerts). There is no explicit sanitization or truncation of test.title before it is used in these notifications. In a vulnerability management system like DefectDojo, test.title can contain sensitive information such as internal project names, specific vulnerability details, or references to unreleased features. This sensitive information could be disclosed to unauthorized users or external systems if notification channels are not strictly controlled.

parent_title=f"Test: {test.title}",
)
serialized_note = serializers.NoteSerializer(

We've notified @mtesauro.


All finding details can be found in the DryRun Security Dashboard.

@github-actions
Copy link
Copy Markdown
Contributor Author

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions Bot added settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR apiv2 conflicts-detected docs unittests parser helm and removed conflicts-detected labels Nov 17, 2025
@github-actions
Copy link
Copy Markdown
Contributor Author

Conflicts have been resolved. A maintainer will review the pull request shortly.

@rossops rossops merged commit 8a7ff18 into dev Nov 17, 2025
151 of 152 checks passed
@rossops rossops deleted the master-into-dev/2.52.2-2.53.0-dev branch November 17, 2025 16:15
Maffooch pushed a commit to valentijnscholten/django-DefectDojo that referenced this pull request Feb 16, 2026
….52.2-2.53.0-dev

Release: Merge back 2.52.2 into dev from: master-into-dev/2.52.2-2.53.0-dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apiv2 docs helm parser settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR unittests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants