Add notification when finding is created via the API#13732
Merged
valentijnscholten merged 5 commits intoDefectDojo:devfrom Nov 19, 2025
Merged
Add notification when finding is created via the API#13732valentijnscholten merged 5 commits intoDefectDojo:devfrom
valentijnscholten merged 5 commits intoDefectDojo:devfrom
Conversation
🔴 Risk threshold exceeded.This pull request includes edits to sensitive codepaths in dojo/api_v2/serializers.py and dojo/test/views.py, which triggered warnings that these file changes are considered sensitive and can be configured (including allowed authors and paths) in .dryrunsecurity.yaml. Review and validate these edits against your security/configuration policy before merging.
🔴 Configured Codepaths Edit in
|
| Vulnerability | Configured Codepaths Edit |
|---|---|
| Description | Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml. |
🔴 Configured Codepaths Edit in dojo/test/views.py
| Vulnerability | Configured Codepaths Edit |
|---|---|
| Description | Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml. |
We've notified @mtesauro.
All finding details can be found in the DryRun Security Dashboard.
Maffooch
approved these changes
Nov 18, 2025
Jino-T
approved these changes
Nov 18, 2025
kiblik
reviewed
Nov 18, 2025
Contributor
kiblik
left a comment
kiblik
left a comment
There was a problem hiding this comment.
Can you write some tests as well, please?
valentijnscholten
requested changes
Nov 19, 2025
Member
valentijnscholten
left a comment
valentijnscholten
left a comment
There was a problem hiding this comment.
Thank you for the PR. Can you ask copilot to add the tests as new methods in the TestNotificationTriggersApi class in test_notifications.py?
valentijnscholten
approved these changes
Nov 19, 2025
Maffooch
pushed a commit
to valentijnscholten/django-DefectDojo
that referenced
this pull request
Feb 16, 2026
* Add notification when finding is created via the API * fix: add tests * fix: Ruff linter COM812 errors * fix: move tests to test_notifications.TestNotificationTriggersApi * fix: W293 Blank line contains whitespace --------- Co-authored-by: Julien Reitzel <jreitzel@veepee.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a notification trigger when a finding is created via the API, like this was already implemented for a finding creation in WebUI.
This was explicitly noted in the UI code with a comment:
TODO: but same should be implemented for API endpoint