fix(init): Initialzer has to fail if migration is not done#13754
Draft
kiblik wants to merge 10000 commits intoDefectDojo:devfrom
Draft
fix(init): Initialzer has to fail if migration is not done#13754kiblik wants to merge 10000 commits intoDefectDojo:devfrom
kiblik wants to merge 10000 commits intoDefectDojo:devfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #13169, we are avoiding failure of
docker/entrypoint-initializer.sh, which is understandable in the related context; however, it is not the best behavior. If migration is missing, we shouldexitwith some error code; otherwise, it is easy to miss bugs in implementation.