Skip to content

Fixes #13555 AND logic not present when filtering Findings via two or more tags#13785

Closed
PoojasPatel013 wants to merge 10 commits intoDefectDojo:bugfixfrom
PoojasPatel013:master
Closed

Fixes #13555 AND logic not present when filtering Findings via two or more tags#13785
PoojasPatel013 wants to merge 10 commits intoDefectDojo:bugfixfrom
PoojasPatel013:master

Conversation

@PoojasPatel013
Copy link
Copy Markdown
Contributor

@PoojasPatel013 PoojasPatel013 commented Nov 29, 2025

Closes #13555

I have applied logic to filters.py, where OR logic is present. Do a review and address any required revisions. Glad if I am even a little helpful in building this amazing app!!

I have kept the existing code as is. And added AND logic with label Tags (AND)
Test results

Have performed manual verification using the UI with a local development instance:

Screenshot 2025-11-29 163131

Setup: Created findings with various tag combinations (e.g., pci, pentest, and cloud).
Action: Tested the new Tags (AND) filter with pci and pentest..
Result: The new filter works as expected without disrupting the existing functionality.

Documentation
N/A (UI enhancement).

@dryrunsecurity
Copy link
Copy Markdown

dryrunsecurity Bot commented Nov 29, 2025

DryRun Security

🔴 Risk threshold exceeded.

This pull request modifies dojo/filters.py, which the scanner flagged as a sensitive edit; sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml. The change is marked at a failing risk threshold but is not set to block the merge.

🔴 Configured Codepaths Edit in dojo/filters.py
Vulnerability Configured Codepaths Edit
Description Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml.

We've notified @mtesauro.


All finding details can be found in the DryRun Security Dashboard.

@valentijnscholten
Copy link
Copy Markdown
Member

Thanks, please base the PR against bugfix or dev as per the guidelines.

@PoojasPatel013 PoojasPatel013 changed the base branch from master to master-into-dev/2.52.1-2.53.0-dev November 29, 2025 13:46
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions Bot added settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR apiv2 docs unittests parser helm labels Nov 30, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@PoojasPatel013 PoojasPatel013 changed the base branch from master-into-dev/2.52.1-2.53.0-dev to bugfix November 30, 2025 04:48
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions Bot added conflicts-detected and removed settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR apiv2 docs unittests labels Nov 30, 2025
@github-actions github-actions Bot removed the parser label Nov 30, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@PoojasPatel013 PoojasPatel013 closed this by deleting the head repository Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI: AND logic not present when filtering Findings via two or more tags

2 participants