Skip to content

🎉 Add 'fix_available' field to legitify #13791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valentijnscholten merged 1 commit into from
Dec 5, 2025
Merged

🎉 Add 'fix_available' field to legitify #13791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion dojo/tools/legitify/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,16 +53,21 @@ def get_findings(self, file, test):
endpoints.add(Endpoint.from_uri(url))

if is_finding:
remediation_steps = policy_info.get("remediationSteps", [])
fix_available = False
if remediation_steps:
fix_available = True
finding = Finding(
description=policy_info.get("description", ""),
dynamic_finding=False,
impact="\n".join(policy_info.get("threat", [])),
mitigation="\n".join(policy_info.get("remediationSteps", [])),
mitigation="\n".join(remediation_steps),
references="\n".join(references),
severity=self.severity_mapper(policy_info.get("severity", "LOW")),
static_finding=True,
title=f'{policy_info.get("namespace", "").capitalize()} | {policy_info.get("title", "")}',
vuln_id_from_tool=policy_info.get("policyName", None),
fix_available=fix_available,
)
finding.unsaved_endpoints = list(endpoints)
findings.append(finding)
Expand Down
2 changes: 2 additions & 0 deletions unittests/tools/test_legitify_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ def test_parse_file_with_many_findings(self):
self.assertEqual("Repository | Default Branch Should Require Code Review", finding.title)
self.assertFalse(finding.dynamic_finding)
self.assertTrue(finding.static_finding)
self.assertTrue(finding.fix_available)
for finding in findings:
for endpoint in finding.unsaved_endpoints:
endpoint.clean()
Expand All @@ -32,6 +33,7 @@ def test_parse_file_with_one_finding(self):
self.assertEqual("Repository | Default Branch Should Require Code Review", finding.title)
self.assertFalse(finding.dynamic_finding)
self.assertTrue(finding.static_finding)
self.assertTrue(finding.fix_available)
for finding in findings:
for endpoint in finding.unsaved_endpoints:
endpoint.clean()
Expand Down