refactor: consolidate GitHub integration into dojo/github/ package#14766
Open
Maffooch wants to merge 1 commit intoDefectDojo:devfrom
Open
refactor: consolidate GitHub integration into dojo/github/ package#14766Maffooch wants to merge 1 commit intoDefectDojo:devfrom
Maffooch wants to merge 1 commit intoDefectDojo:devfrom
Conversation
27618ac to
989b318
Compare
Collapse dojo/github.py and dojo/github_issue_link/ into a single dojo/github/ package matching the canonical dojo/url/ reference layout described in CLAUDE.md (models, admin, services, ui/forms, ui/views, ui/urls, templates). Backward-compat re-exports left in dojo/models.py and dojo/forms.py. No behavior change, no migrations. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
989b318 to
a8246a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dojo/github.py,dojo/github_issue_link/, GitHub forms indojo/forms.py, GitHub models indojo/models.py, GitHub templates) into a single self-containeddojo/github/package.dojo/url/reference layout from CLAUDE.md:__init__.py+admin.py+models.py+services.py+ui/{__init__,forms,urls,views}.py+templates/dojo/.Github(api_key).get_user()credential check fromnew_githubview intoservices.validate_github_credentials()per CLAUDE.md Phase 2 ("external integration calls belong in services.py").dojo/models.py(5 GITHUB models) anddojo/forms.py(6 GITHUB forms) per the playbook.dojo/utils.pyanddojo/urls.pyupdated to use the new canonical paths.settings.dist.pyleft in place (out of scope per task; conceptually belong with SSO).dojoapp preservesapp_label).Test plan
python manage.py check— System check identified no issuespython manage.py makemigrations --check --dry-run— No changes detectedpython manage.py test unittests -k github— 29/29 tests passdojo.modelsanddojo.forms(model/form identity matches new canonical paths)dojo.github.{models,services},dojo.github.ui.{forms,urls}dojo/github/templates/dojo/{github,new_github,delete_github}.htmlGITHUB_Conf,GITHUB_Issue,GITHUB_PKey,GITHUB_Clone,GITHUB_Details_Cacheruff checkclean on all touched filesenable_github=True:/github,/github/add,/github/<id>/delete; create finding linked toGITHUB_PKey-configured product, push to GitHub, close, reopen🤖 Generated with Claude Code