Skip to content

test(perf) on dev: re-enable import performance tests with recalibrated query counts#14967

Merged
mtesauro merged 1 commit into
DefectDojo:devfrom
valentijnscholten:re-enable-import-perf-tests
Jun 8, 2026
Merged

test(perf) on dev: re-enable import performance tests with recalibrated query counts#14967
mtesauro merged 1 commit into
DefectDojo:devfrom
valentijnscholten:re-enable-import-perf-tests

Conversation

@valentijnscholten

Copy link
Copy Markdown
Member

Summary

  • Re-enables TestDojoImporterPerformanceSmall and TestDojoImporterPerformanceSmallLocations which were skipped pending re-baseline after the RBAC→legacy authorization migration
  • Recalibrates all 32 expected query counts using scripts/update_performance_test_counts.py — counts decreased by 1–7 queries across the board, consistent with legacy auth having lower per-action overhead (no role-permission lookups, simpler permission_to_action dispatch)
  • Removes the now-unused unittest.skip import
  • Verification run confirms all performance tests pass

…y counts

Re-baseline expected query counts after upstream merge that switched from
RBAC to legacy authorization. Legacy auth has lower per-action overhead
(no role-permission lookups, simpler dispatch), so all counts decreased
by 1-7 queries. Also removes the unused `unittest.skip` import.
@valentijnscholten valentijnscholten changed the title test(perf): re-enable import performance tests with recalibrated query counts test(perf) on dev: re-enable import performance tests with recalibrated query counts Jun 7, 2026
@valentijnscholten valentijnscholten added this to the 2.60.0 milestone Jun 7, 2026

@mtesauro mtesauro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro
mtesauro requested review from Jino-T, blakeaowens and dogboat and removed request for Maffooch June 8, 2026 02:25
@mtesauro
mtesauro merged commit daf6d57 into DefectDojo:dev Jun 8, 2026
401 of 412 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants