Skip to content

test(perf) on bugfix: re-enable import performance tests with recalibrated query counts#14968

Merged
mtesauro merged 1 commit into
DefectDojo:bugfixfrom
valentijnscholten:re-enable-import-perf-tests-bugfix
Jun 8, 2026
Merged

test(perf) on bugfix: re-enable import performance tests with recalibrated query counts#14968
mtesauro merged 1 commit into
DefectDojo:bugfixfrom
valentijnscholten:re-enable-import-perf-tests-bugfix

Conversation

@valentijnscholten

@valentijnscholten valentijnscholten commented Jun 7, 2026

Copy link
Copy Markdown
Member

Summary

  • Re-enables TestDojoImporterPerformanceSmall and TestDojoImporterPerformanceSmallLocations which were skipped pending re-baseline after the RBAC→legacy authorization migration
  • Recalibrates expected query counts: legacy auth has lower per-action overhead (no role-permission lookups, simpler dispatch), so all counts decreased by 1–7 queries per step
  • Removes the unused unittest.skip import

…y counts

Re-baseline expected query counts after upstream merge that switched from
RBAC to legacy authorization. Legacy auth has lower per-action overhead
(no role-permission lookups, simpler dispatch), so all counts decreased
by 1-7 queries. Also removes the unused `unittest.skip` import.
@valentijnscholten valentijnscholten changed the title test(perf): re-enable import performance tests with recalibrated query counts test(perf) on bugfix: re-enable import performance tests with recalibrated query counts Jun 7, 2026
@valentijnscholten valentijnscholten changed the title test(perf) on bugfix: re-enable import performance tests with recalibrated query counts perf(importers): batch BurpRawRequestResponse inserts + re-enable perf tests Jun 7, 2026
@valentijnscholten
valentijnscholten force-pushed the re-enable-import-perf-tests-bugfix branch from 3c2c926 to a3104b6 Compare June 7, 2026 10:07
@valentijnscholten valentijnscholten changed the title perf(importers): batch BurpRawRequestResponse inserts + re-enable perf tests test(perf) on bugfix: re-enable import performance tests with recalibrated query counts Jun 7, 2026

@mtesauro mtesauro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro
mtesauro requested review from Jino-T, blakeaowens and rossops and removed request for Maffooch June 8, 2026 02:39
@mtesauro mtesauro added this to the 2.59.1 milestone Jun 8, 2026
@mtesauro mtesauro modified the milestones: 2.59.1, 2.60.0 Jun 8, 2026
@mtesauro
mtesauro merged commit 8178281 into DefectDojo:bugfix Jun 8, 2026
474 of 551 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants