Skip to content

Scope location and endpoint reference writes to authorized products#15300

Open
svader0 wants to merge 1 commit into
DefectDojo:devfrom
svader0:harden-location-reference-authz
Open

Scope location and endpoint reference writes to authorized products#15300
svader0 wants to merge 1 commit into
DefectDojo:devfrom
svader0:harden-location-reference-authz

Conversation

@svader0

@svader0 svader0 commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Hardening and consistency improvement to object-level authorization on several API and UI write paths that associate locations and endpoints with findings and products.

These paths now restrict the selectable references to objects the requesting user is authorized for, matching the scoping the UI forms and dedicated viewsets already apply. No functional change for correctly-permissioned users.

Adds regression tests covering same-product (allowed) and cross-product (rejected) writes.

@svader0
svader0 force-pushed the harden-location-reference-authz branch 2 times, most recently from 88d6aff to 0a9d535 Compare July 21, 2026 07:26
@svader0
svader0 marked this pull request as ready for review July 21, 2026 07:34
@dryrunsecurity

dryrunsecurity Bot commented Jul 21, 2026

Copy link
Copy Markdown

DryRun Security

This pull request contains a critical finding where a sensitive codepath file, dojo/api_v2/serializers.py, was modified by an unauthorized author, 'svader0', violating configured security policies. Although the finding is non-blocking, it poses a significant risk due to the sensitivity of the modified code.

🔴 Configured Sensitive Codepath Modified by Non-Allowed Author in dojo/api_v2/serializers.py (drs_d7d3d9cc)
Vulnerability Configured Sensitive Codepath Modified by Non-Allowed Author
Description File 'dojo/api_v2/serializers.py' matches configured sensitive codepath pattern 'dojo/api_v2/*.py' and was modified by 'svader0' (commit b435880) who is not in the allowed authors list.

We've notified @mtesauro.


Comment to provide feedback on these findings.

Report false positive: @dryrunsecurity fp [FINDING ID] [FEEDBACK]
Report low-impact: @dryrunsecurity nit [FINDING ID] [FEEDBACK]

Example: @dryrunsecurity fp drs_90eda195 This code is not user-facing

All finding details can be found in the DryRun Security Dashboard.

Hardening to object-level authorization on several API and UI write paths that
associate locations and endpoints with findings and products. These paths now
restrict the selectable references to the objects the requesting user is
authorized for, matching the scoping the UI forms and dedicated viewsets
already apply. Adds regression tests. No functional change for
correctly-permissioned users.
@svader0
svader0 force-pushed the harden-location-reference-authz branch from 0a9d535 to b435880 Compare July 21, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant