register Goblin RWA token on Pharos#20006
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ERC-4626 registry adds a ChangesGoblin registry configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The adapter at goblin exports TVL: |
RohanNero
left a comment
There was a problem hiding this comment.
Hello, thank you for the PR. I have a couple of questions/notes:
- The vault returns the null address for
asset(), sototalAssets()is being added to balances as PROS token. Is this accurate, or should it be USDC? - I didn't see USDC being transferred when GPCI was minted, is it sent in a separate transaction?: https://www.pharosscan.xyz/tx/0xb7b1c11f7e4c8140e5833fd249328c64cec928ff6ec471e75ae130f60b778990
- If the backing for GPCI is offchain, could you please fill out one of our RWA submission forms instead?:
|
This is an RWA token registered on Phraos by Goblin, issued using ERC-4626.
Summary by CodeRabbit