Skip to content

register Goblin RWA token on Pharos#20006

Open
ericEnjoy wants to merge 5 commits into
DefiLlama:mainfrom
Hyperionxyz:main
Open

register Goblin RWA token on Pharos#20006
ericEnjoy wants to merge 5 commits into
DefiLlama:mainfrom
Hyperionxyz:main

Conversation

@ericEnjoy

@ericEnjoy ericEnjoy commented Jul 13, 2026

Copy link
Copy Markdown

This is an RWA token registered on Phraos by Goblin, issued using ERC-4626.

Summary by CodeRabbit

  • New Features
    • Added support for the Goblin protocol.
    • Added TVL tracking for Goblin’s Pharos vaults using the defined methodology.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0cb272ec-0e35-478a-9c12-7f1da5807878

📥 Commits

Reviewing files that changed from the base of the PR and between ecc5f22 and 9c8e3e8.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • registries/erc4626.js

📝 Walkthrough

Walkthrough

The ERC-4626 registry adds a goblin protocol entry with a Pharos vault mapping and methodology description. Existing export wiring remains unchanged.

Changes

Goblin registry configuration

Layer / File(s) Summary
Add Goblin protocol configuration
registries/erc4626.js
Adds the goblin configuration with the GoblinPrivateCreditI Pharos vault and TVL methodology text.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is too brief and omits the required new-listing fields from the template, such as name, chain, website, methodology, and token details. Fill in the new-listing template sections with the required protocol details, links, token info, methodology, and any relevant audit/oracle data.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: registering Goblin's RWA token on Pharos.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

The adapter at goblin exports TVL:

pharos                    6.49 M

total                    6.49 M 

@RohanNero RohanNero left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you for the PR. I have a couple of questions/notes:

  1. The vault returns the null address for asset(), so totalAssets() is being added to balances as PROS token. Is this accurate, or should it be USDC?
  2. I didn't see USDC being transferred when GPCI was minted, is it sent in a separate transaction?: https://www.pharosscan.xyz/tx/0xb7b1c11f7e4c8140e5833fd249328c64cec928ff6ec471e75ae130f60b778990
  3. If the backing for GPCI is offchain, could you please fill out one of our RWA submission forms instead?:

@ericEnjoy

Copy link
Copy Markdown
Author

Hello, thank you for the PR. I have a couple of questions/notes:

  1. The vault returns the null address for asset(), so totalAssets() is being added to balances as PROS token. Is this accurate, or should it be USDC?

  2. I didn't see USDC being transferred when GPCI was minted, is it sent in a separate transaction?: https://www.pharosscan.xyz/tx/0xb7b1c11f7e4c8140e5833fd249328c64cec928ff6ec471e75ae130f60b778990

  3. If the backing for GPCI is offchain, could you please fill out one of our RWA submission forms instead?:

  1. It's USDC, and it is backed by offchain assets.
  2. We have already submit the form, but have no idea how to related to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants