Y10K#20052
Conversation
|
Error while running adapter at projects/Y10k-Capital: |
📝 WalkthroughWalkthroughAdds Y10k-Capital TVL adapters for Ethereum and SEI, summing their ERC-4626 contracts and marking the module as double-counted. ChangesY10k-Capital Adapter
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The adapter at projects/y10k-capital exports TVL: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@projects/y10k-capital/index.js`:
- Line 9: Update the eY10K TVL path to use the canonical OG4626 wrapper,
including the sumTokens2({ api }) processing after api.erc4626Sum, so reported
balances are unwrapped underlying assets rather than vault shares. Replace the
direct return in the affected export while preserving the eY10K call
configuration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 1127240a-7f0d-4dad-a49b-8fed270fb094
📒 Files selected for processing (1)
projects/y10k-capital/index.js
| doublecounted: true, | ||
| ethereum: { | ||
| tvl: async (api) => { | ||
| return api.erc4626Sum({ calls: [eY10K], isOG4626: true}) |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Use the OG4626 wrapper so balances are unwrapped before reporting TVL.
The canonical sumERC4626VaultsExport2 path runs sumTokens2({ api }) after api.erc4626Sum; returning api.erc4626Sum directly can expose eY10K share balances instead of the underlying assets, resulting in incorrect TVL.
+const { sumERC4626VaultsExport2 } = require('../helper/erc4626')
+
const ADDRESSES = require('../helper/coreAssets.json')
@@
- tvl: async (api) => {
- return api.erc4626Sum({ calls: [eY10K], isOG4626: true})
- }
+ tvl: sumERC4626VaultsExport2({ vaults: [eY10K] })📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| return api.erc4626Sum({ calls: [eY10K], isOG4626: true}) | |
| const { sumERC4626VaultsExport2 } = require('../helper/erc4626') | |
| tvl: sumERC4626VaultsExport2({ vaults: [eY10K] }) |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@projects/y10k-capital/index.js` at line 9, Update the eY10K TVL path to use
the canonical OG4626 wrapper, including the sumTokens2({ api }) processing after
api.erc4626Sum, so reported balances are unwrapped underlying assets rather than
vault shares. Replace the direct return in the affected export while preserving
the eY10K call configuration.
|
The adapter at projects/y10k-capital exports TVL: |
There was a problem hiding this comment.
♻️ Duplicate comments (1)
projects/y10k-capital/index.js (1)
12-14:⚠️ Potential issue | 🟠 MajorUse
sumERC4626VaultsExport2for both chains.Both exports bypass the
sumTokens2({ api })transformation required for OG4626 vaults, risking incorrect TVL based on vault shares rather than underlying assets.
projects/y10k-capital/index.js#L12-L14: replace the Ethereum implementation withsumERC4626VaultsExport2({ vaults: [eY10K] }).projects/y10k-capital/index.js#L17-L19: replace the SEI implementation withsumERC4626VaultsExport2({ vaults: [y10kPYUSD] }).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@projects/y10k-capital/index.js` around lines 12 - 14, The Ethereum and SEI TVL implementations in projects/y10k-capital/index.js (lines 12-14 and 17-19) must both use sumERC4626VaultsExport2 instead of api.erc4626Sum. Update the Ethereum entry to pass eY10K and the SEI entry to pass y10kPYUSD via the vaults option.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@projects/y10k-capital/index.js`:
- Around line 12-14: The Ethereum and SEI TVL implementations in
projects/y10k-capital/index.js (lines 12-14 and 17-19) must both use
sumERC4626VaultsExport2 instead of api.erc4626Sum. Update the Ethereum entry to
pass eY10K and the SEI entry to pass y10kPYUSD via the vaults option.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 43961915-6af3-44f0-a748-ac840c114be1
📒 Files selected for processing (1)
projects/y10k-capital/index.js
|
Thank you for the PR, I've added Y10K in #20059 |
2 participants
NOTE
Please enable "Allow edits by maintainers" while putting up the PR.
If you would like to add a
volume/fees/revenueadapter please submit the PR here.Once your adapter has been merged, it takes time to show on the UI. If more than 24 hours have passed, please let us know in Discord.
Sorry, We no longer accept fetch adapter for new projects, we prefer the tvl to computed from blockchain data, if you have trouble with creating a the adapter, please hop onto our discord, we are happy to assist you.
For updating listing info Please send a mail to metadata@defillama.com
Please do not add new npm dependencies, do not edit/push
pnpm-lock.yamlfile as part of your changes(Needs to be filled only for new listings)
Name (to be shown on DefiLlama): Y10K Capital
Twitter Link: https://x.com/y10kcapital
List of audit links if any:
Website Link: https://www.y10k.capital/
Logo (High resolution, will be shown with rounded borders): https://imgur.com/a/h8Hf7NP
Current TVL:
Treasury Addresses (if the protocol has treasury)
Chain: Ethereum
Coingecko ID (so your TVL can appear on Coingecko, leave empty if not listed): (https://api.coingecko.com/api/v3/coins/list)
Coinmarketcap ID (so your TVL can appear on Coinmarketcap, leave empty if not listed): (https://api.coinmarketcap.com/data-api/v3/map/all?listing_status=active,inactive,untracked&start=1&limit=10000)
Short Description (to be shown on DefiLlama): Actively managed onchain vehicle by Yield Network and RockawayX team focused on private onchain liquidity deals.
Token address and ticker if any:
Category (full list at https://defillama.com/categories) *Please choose only one: Risk Curator
Oracle Provider(s): Specify the oracle(s) used (e.g., Chainlink, Band, API3, TWAP, etc.):
Implementation Details: Briefly describe how the oracle is integrated into your project:
Documentation/Proof: Provide links to documentation or any other resources that verify the oracle's usage:
forkedFrom (Does your project originate from another project):
methodology (what is being counted as tvl, how is tvl being calculated):
Github org/user (Optional, if your code is open source, we can track activity):
Does this project have a referral program?
Summary by CodeRabbit
New Features
Bug Fixes