Update owner addresses in sumTokens.js#20069
Conversation
📝 WalkthroughWalkthroughSuperform network configuration updates Ethereum and Arbitrum blacklists, the Fantom factory, and shared contract constants. Per-chain TVL export wiring remains unchanged. ChangesSuperform configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@projects/superform/index.js`:
- Around line 3-24: Normalize the addresses in the blacklist configuration used
by the blacklist filtering comparison so they match the lowercase value from
p.vault.toLowerCase(). Update the blacklistedVaults entries or normalize both
operands before includes(), ensuring all affected network configurations,
including arbitrum, correctly exclude blacklisted vault TVL.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 42ab7436-5310-45bd-a7fd-5e508df7c17a
📒 Files selected for processing (1)
projects/superform/index.js
| '0x46531ea0E7cec64b14181d45F8C6798a1cE45da1', | ||
| '0x3211d27a1A1B8E40C7974F6951935303e6e56DBE', | ||
| '0x46531ea0E7cec64b14181d45F8C6798a1cE45da1', | ||
| '0x46531ea0E7cec64b14181d45F8C6798a1cE45da1', | ||
| '0x46531ea0E7cec64b14181d45F8C6798a1cE45da1', | ||
| '0x46531ea0E7cec64b14181d45F8C6798a1cE45da1', | ||
| '0x46531ea0E7cec64b14181d45F8C6798a1cE45da1', | ||
| '0x46531ea0E7cec64b14181d45F8C6798a1cE45da1', | ||
| '0x46531ea0E7cec64b14181d45F8C6798a1cE45da1' | ||
| ] }, | ||
| arbitrum: { blacklistedVaults: [ | ||
| '0xd3a17928245064b6df5095a76e277fe441d538a4', | ||
| '0xabc07bf91469c5450d6941dd0770e6e6761b90d6', | ||
| '0x6f28cafe12bd97e474a52bcbfea6f2c18ae0f53d', | ||
| '0x0ace2dc3995acd739ae5e0599e71a5524b93b886', | ||
| '0xb9bfbb35c2ed588a42f9fd1120929c607b463192', | ||
| '0xbc323e3564fb498e55cdc83a3ea6bb1af8402d6b', | ||
| '0x1fd865a55eaf5333e6374fb3ad66d22e9885d3aa', | ||
| '0x866eb09d3d1397b8a28cfe5dceeaed9362840385', | ||
| '0xd63ace62b925361fc588734022718e919a8081ac', | ||
| '0xa135d7f10545e3a45e24e79ecd4e4c3c78cf56bf', | ||
| '0x806e8538fc05774ea83d9428f778e423f6492475', | ||
| '0x46531ea0E7cec64b14181d45F8C6798a1cE45da1', | ||
| '0x46531ea0E7cec64b14181d45F8C6798a1cE45da1', | ||
| '0x46531ea0E7cec64b14181d45F8C6798a1cE45da1', | ||
| '0x46531ea0E7cec64b14181d45F8C6798a1cE45da1', | ||
| '0x3211d27a1A1B8E40C7974F6951935303e6e56DBE', | ||
| '0x3211d27a1A1B8E40C7974F6951935303e6e56DBE', | ||
| '0x3211d27a1A1B8E40C7974F6951935303e6e56DBE', | ||
| '0x3211d27a1A1B8E40C7974F6951935303e6e56DBE', | ||
| '0x3211d27a1A1B8E40C7974F6951935303e6e56DBE', | ||
| '0x46531ea0E7cec64b14181d45F8C6798a1cE45da1', | ||
| '0x46531ea0E7cec64b14181d45F8C6798a1cE45da1', |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Normalize blacklist addresses before comparison.
Line 55 compares p.vault.toLowerCase() against blacklistedVaults with case-sensitive includes(). These updated entries contain uppercase characters, so the blacklist will not match and blacklisted vault TVL will be counted.
Store the entries lowercase or normalize both sides before filtering.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@projects/superform/index.js` around lines 3 - 24, Normalize the addresses in
the blacklist configuration used by the blacklist filtering comparison so they
match the lowercase value from p.vault.toLowerCase(). Update the
blacklistedVaults entries or normalize both operands before includes(), ensuring
all affected network configurations, including arbitrum, correctly exclude
blacklisted vault TVL.
NOTE
Please enable "Allow edits by maintainers" while putting up the PR.
If you would like to add a
volume/fees/revenueadapter please submit the PR here.Once your adapter has been merged, it takes time to show on the UI. If more than 24 hours have passed, please let us know in Discord.
Sorry, We no longer accept fetch adapter for new projects, we prefer the tvl to computed from blockchain data, if you have trouble with creating a the adapter, please hop onto our discord, we are happy to assist you.
For updating listing info Please send a mail to metadata@defillama.com
Please do not add new npm dependencies, do not edit/push
pnpm-lock.yamlfile as part of your changes(Needs to be filled only for new listings)
Name (to be shown on DefiLlama):
Twitter Link:
List of audit links if any:
Website Link:
Logo (High resolution, will be shown with rounded borders):
Current TVL:
Treasury Addresses (if the protocol has treasury)
Chain:
Coingecko ID (so your TVL can appear on Coingecko, leave empty if not listed): (https://api.coingecko.com/api/v3/coins/list)
Coinmarketcap ID (so your TVL can appear on Coinmarketcap, leave empty if not listed): (https://api.coinmarketcap.com/data-api/v3/map/all?listing_status=active,inactive,untracked&start=1&limit=10000)
Short Description (to be shown on DefiLlama):
Token address and ticker if any:
Category (full list at https://defillama.com/categories) *Please choose only one:
Oracle Provider(s): Specify the oracle(s) used (e.g., Chainlink, Band, API3, TWAP, etc.):
Implementation Details: Briefly describe how the oracle is integrated into your project:
Documentation/Proof: Provide links to documentation or any other resources that verify the oracle's usage:
forkedFrom (Does your project originate from another project):
methodology (what is being counted as tvl, how is tvl being calculated):
Github org/user (Optional, if your code is open source, we can track activity):
Does this project have a referral program?
Summary by CodeRabbit