Skip to content

Update owner addresses in sumTokens.js#20069

Closed
williamspatrick3353-droid wants to merge 1 commit into
DefiLlama:mainfrom
williamspatrick3353-droid:patch-54
Closed

Update owner addresses in sumTokens.js#20069
williamspatrick3353-droid wants to merge 1 commit into
DefiLlama:mainfrom
williamspatrick3353-droid:patch-54

Conversation

@williamspatrick3353-droid

@williamspatrick3353-droid williamspatrick3353-droid commented Jul 16, 2026

Copy link
Copy Markdown

NOTE

Please enable "Allow edits by maintainers" while putting up the PR.


  1. If you would like to add a volume/fees/revenue adapter please submit the PR here.

  2. Once your adapter has been merged, it takes time to show on the UI. If more than 24 hours have passed, please let us know in Discord.

  3. Sorry, We no longer accept fetch adapter for new projects, we prefer the tvl to computed from blockchain data, if you have trouble with creating a the adapter, please hop onto our discord, we are happy to assist you.

  4. For updating listing info Please send a mail to metadata@defillama.com

  5. Please do not add new npm dependencies, do not edit/push pnpm-lock.yaml file as part of your changes


(Needs to be filled only for new listings)

Name (to be shown on DefiLlama):
Twitter Link:
List of audit links if any:
Website Link:
Logo (High resolution, will be shown with rounded borders):
Current TVL:
Treasury Addresses (if the protocol has treasury)
Chain:
Coingecko ID (so your TVL can appear on Coingecko, leave empty if not listed): (https://api.coingecko.com/api/v3/coins/list)
Coinmarketcap ID (so your TVL can appear on Coinmarketcap, leave empty if not listed): (https://api.coinmarketcap.com/data-api/v3/map/all?listing_status=active,inactive,untracked&start=1&limit=10000)
Short Description (to be shown on DefiLlama):
Token address and ticker if any:
Category (full list at https://defillama.com/categories) *Please choose only one:
Oracle Provider(s): Specify the oracle(s) used (e.g., Chainlink, Band, API3, TWAP, etc.):
Implementation Details: Briefly describe how the oracle is integrated into your project:
Documentation/Proof: Provide links to documentation or any other resources that verify the oracle's usage:
forkedFrom (Does your project originate from another project):
methodology (what is being counted as tvl, how is tvl being calculated):
Github org/user (Optional, if your code is open source, we can track activity):
Does this project have a referral program?

Summary by CodeRabbit

  • Updates
    • Updated Superform network configuration and contract addresses.
    • Refreshed blacklisted vault lists for Ethereum and Arbitrum.
    • Updated the Fantom factory and default aggregator configuration.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Superform network configuration updates Ethereum and Arbitrum blacklists, the Fantom factory, and shared contract constants. Per-chain TVL export wiring remains unchanged.

Changes

Superform configuration

Layer / File(s) Summary
Address configuration and TVL exports
projects/superform/index.js
Updates Ethereum and Arbitrum blacklisted vaults, the Fantom factory, and shared factory and aggregator addresses while retaining per-chain tvl exports.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions sumTokens.js owner addresses, but the changed file is projects/superform/index.js with Superform config and contract address updates. Rename the title to reflect the actual change, e.g. updating Superform network config and contract addresses in projects/superform/index.js.
Description check ⚠️ Warning The description is only the boilerplate template and does not summarize the actual Superform address/config updates. Add a brief change summary, affected files, and what addresses or config values were updated; keep the template only if this is a new listing.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@projects/superform/index.js`:
- Around line 3-24: Normalize the addresses in the blacklist configuration used
by the blacklist filtering comparison so they match the lowercase value from
p.vault.toLowerCase(). Update the blacklistedVaults entries or normalize both
operands before includes(), ensuring all affected network configurations,
including arbitrum, correctly exclude blacklisted vault TVL.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 42ab7436-5310-45bd-a7fd-5e508df7c17a

📥 Commits

Reviewing files that changed from the base of the PR and between e031d7f and b8b58e4.

📒 Files selected for processing (1)
  • projects/superform/index.js

Comment on lines +3 to +24
'0x46531ea0E7cec64b14181d45F8C6798a1cE45da1',
'0x3211d27a1A1B8E40C7974F6951935303e6e56DBE',
'0x46531ea0E7cec64b14181d45F8C6798a1cE45da1',
'0x46531ea0E7cec64b14181d45F8C6798a1cE45da1',
'0x46531ea0E7cec64b14181d45F8C6798a1cE45da1',
'0x46531ea0E7cec64b14181d45F8C6798a1cE45da1',
'0x46531ea0E7cec64b14181d45F8C6798a1cE45da1',
'0x46531ea0E7cec64b14181d45F8C6798a1cE45da1',
'0x46531ea0E7cec64b14181d45F8C6798a1cE45da1'
] },
arbitrum: { blacklistedVaults: [
'0xd3a17928245064b6df5095a76e277fe441d538a4',
'0xabc07bf91469c5450d6941dd0770e6e6761b90d6',
'0x6f28cafe12bd97e474a52bcbfea6f2c18ae0f53d',
'0x0ace2dc3995acd739ae5e0599e71a5524b93b886',
'0xb9bfbb35c2ed588a42f9fd1120929c607b463192',
'0xbc323e3564fb498e55cdc83a3ea6bb1af8402d6b',
'0x1fd865a55eaf5333e6374fb3ad66d22e9885d3aa',
'0x866eb09d3d1397b8a28cfe5dceeaed9362840385',
'0xd63ace62b925361fc588734022718e919a8081ac',
'0xa135d7f10545e3a45e24e79ecd4e4c3c78cf56bf',
'0x806e8538fc05774ea83d9428f778e423f6492475',
'0x46531ea0E7cec64b14181d45F8C6798a1cE45da1',
'0x46531ea0E7cec64b14181d45F8C6798a1cE45da1',
'0x46531ea0E7cec64b14181d45F8C6798a1cE45da1',
'0x46531ea0E7cec64b14181d45F8C6798a1cE45da1',
'0x3211d27a1A1B8E40C7974F6951935303e6e56DBE',
'0x3211d27a1A1B8E40C7974F6951935303e6e56DBE',
'0x3211d27a1A1B8E40C7974F6951935303e6e56DBE',
'0x3211d27a1A1B8E40C7974F6951935303e6e56DBE',
'0x3211d27a1A1B8E40C7974F6951935303e6e56DBE',
'0x46531ea0E7cec64b14181d45F8C6798a1cE45da1',
'0x46531ea0E7cec64b14181d45F8C6798a1cE45da1',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Normalize blacklist addresses before comparison.

Line 55 compares p.vault.toLowerCase() against blacklistedVaults with case-sensitive includes(). These updated entries contain uppercase characters, so the blacklist will not match and blacklisted vault TVL will be counted.

Store the entries lowercase or normalize both sides before filtering.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@projects/superform/index.js` around lines 3 - 24, Normalize the addresses in
the blacklist configuration used by the blacklist filtering comparison so they
match the lowercase value from p.vault.toLowerCase(). Update the
blacklistedVaults entries or normalize both operands before includes(), ensuring
all affected network configurations, including arbitrum, correctly exclude
blacklisted vault TVL.

@coderabbitai coderabbitai Bot mentioned this pull request Jul 16, 2026
@RohanNero RohanNero closed this Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants