quickswap: split revenue 30% foundation / 70% holders from Nov 5, 2025#8042
Merged
Conversation
Governance vote (snapshot quickvote.eth) executed ~9PM Nov 4, 2025 changed the protocol revenue split to 30% foundation / 70% holders across all QuickSwap children. Date-gated in V2, V3 and V4 (first full day Nov 5); total protocol take unchanged, only the foundation/holders split shifts.
Contributor
Summary by CodeRabbit
WalkthroughQuickSwap v2, v3, and v4 dex adapters are updated to apply a time-based fee/revenue split keyed on a November 5, 2025 timestamp cutoff (post governance vote), replacing static ratio constants with computed logic, and updating adapter methodology description strings accordingly. ChangesQuickSwap fee split update
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 10 | ❌ 5❌ Failed checks (5 warnings)
✅ Passed checks (10 passed)
✨ Finishing Touches📝 Generate docstrings
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The quickswap-v2.ts adapter exports: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@dexs/quickswap-v2.ts`:
- Line 35: The methodology text for the Quickswap v2 protocol revenue split is
inconsistent with the cutoff logic: the `ProtocolRevenue` description currently
says the new 30% split starts “since Nov 4, 2025,” but the actual effective date
in the surrounding QuickSwap v2 methodology is Nov 5, 2025. Update the affected
`ProtocolRevenue` strings in `dexs/quickswap-v2.ts` to say “since Nov 5, 2025”
so they match the `timestamp >= nov5th2025` behavior and avoid misleading users.
In `@dexs/quickswap-v3.ts`:
- Line 77: The methodology text for the protocol revenue split is inconsistent
with the actual cutoff used in the QuickSwap logic. Update the `ProtocolRevenue`
description in `quickswap-v3.ts` (and the matching text in `quickswap-v2.ts` if
present) so it says the new split applies starting Nov 5, 2025, matching the
`timestamp >= nov5th2025` check used in the revenue calculation.
In `@dexs/quickswap-v4.ts`:
- Line 76: The methodology text for the protocol revenue split is inconsistent
with the actual cutoff used in the Quickswap logic. Update the descriptive
string in quickswap-v4.ts (and the related metadata entry it shares) so it
matches the effective date applied by the timestamp check in the Quickswap
revenue calculation, which uses nov5th2025 / Nov 5, 2025 00:00 UTC. Keep the
wording aligned with the same convention used in quickswap-v2.ts and
quickswap-v3.ts.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 75770029-37a5-4896-82d9-1e68a0fc0628
📒 Files selected for processing (3)
dexs/quickswap-v2.tsdexs/quickswap-v3.tsdexs/quickswap-v4.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
QuickSwap governance vote (snapshot quickvote.eth) changed the protocol revenue split to 30% foundation / 70% holders across all QuickSwap children.
Vote executed ~9PM Nov 4, 2025, so the first full day under the new split is Nov 5, 2025 (
1762300800). The total protocol take is unchanged; only the foundation/holders split shifts.Changes
getRatiosswaps to 30/70 at the cutoffPerps and liquidityHub adapters untouched (no foundation/holders split).
A refill is needed to apply the corrected historical split.