Skip to content

Commit 729e737

Browse files
Did all the nitpicks required
Coderabbit suggestion Signed-off-by: Shahm Najeeb <Nirt_12023@outlook.com>
1 parent 10698a0 commit 729e737

File tree

5 files changed

+44
-41
lines changed

5 files changed

+44
-41
lines changed

CODE/Logicytics.py

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -137,12 +137,9 @@ def handle_special_actions():
137137

138138
# Deprecated, remove in v3.3.0
139139
if ACTION == "extra":
140-
print("\033[91mDeprecationWarning: "
141-
"A call to the deprecated feature `extra` has been called, "
142-
"this feature has been removed as it doesn't follow "
143-
"the required code standards or aim of Logicytics.\033[0m")
144-
log.info("No flag is supplied due to --extra flag deprecation, will show help menu instead")
145-
Flag.show_help_menu()
140+
print("\033[91mDeprecationWarning: The `extra` feature has been removed! 🚫\n"
141+
"Why? It didn't match our code quality standards.\n"
142+
"What to use instead? Check out our new features with --help\033[0m")
146143
input("Press Enter to exit...")
147144
exit(0)
148145

@@ -178,12 +175,9 @@ def handle_special_actions():
178175

179176
# Deprecated, remove in v3.3.0
180177
if ACTION == "unzip_extra":
181-
print("\033[91mDeprecationWarning: "
182-
"A call to the deprecated feature `unzip-extra` has been called, "
183-
"this feature has been removed as it doesn't follow "
184-
"the required code standards or aim of Logicytics.\033[0m")
185-
log.info("No flag is supplied due to --unzip-extra flag deprecation, will show help menu instead")
186-
Flag.show_help_menu()
178+
print("\033[91mDeprecationWarning: The `unzip_extra` feature has been removed! 🚫\n"
179+
"Why? It didn't match our code quality standards.\n"
180+
"What to use instead? Check out our new features with --help\033[0m")
187181
input("Press Enter to exit...")
188182
exit(0)
189183

CODE/VulnScan/README.md

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,15 @@
11
# VulnScan Documentation
22

33
> [!WARNING]
4-
> VulnScan will be moved to a different repository soon.
5-
> This part of the repository will be archived and the new repository will be linked here.
6-
> The `pkl` and `pth` files will stay here, linked properly for `vulnscan.py`,
7-
> VulnScan will NOT be moved to the other repository.
4+
> # VulnScan Migration Notice 🚨
5+
>
6+
> VulnScan is moving to a new home! Here's what you need to know:
7+
> - This repository section will be archived
8+
> - A link to the new repository will be added here
9+
> - The `pkl` and `pth` files will stay here (they'll work with `vulnscan.py`)
10+
> - VulnScan itself will NOT be moved to the other repository
11+
>
12+
> This will occur in version `3.2.0` of Logicytics.
813
914
## Overview
1015

CODE/VulnScan/v3/_generate_data.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,10 @@ def generate_file_content(extensions: str) -> tuple[str, str]:
187187

188188
if CODE_NAME == 'SenseMacro':
189189
print(
190-
"\033[91mDeprecationWarning: A call to the deprecated feature SenseMacro has been called, this has been removed due to instability issues, going with default settings (Model Sense).\033[0m")
190+
"\033[91mDeprecationWarning: SenseMacro has been removed due to instability issues. "
191+
"Please use 'Sense' instead for better stability and performance. "
192+
"Defaulting to 'Sense' settings for now.\033[0m"
193+
)
191194
CODE_NAME = 'Sense'
192195

193196
if CODE_NAME == 'Sense':

CODE/logicytics/Flag.py

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -172,16 +172,13 @@ def __available_arguments(cls) -> tuple[argparse.Namespace, argparse.ArgumentPar
172172
parser.add_argument(
173173
"--unzip-extra",
174174
action="store_true",
175-
help="Unzip the extra directory zip File "
176-
f"{cls.colorify('- Use on your own device only -', 'y')}.",
175+
help=f"{cls.colorify('[REMOVED]', 'r')} Unzip the extra directory zip File "
177176
)
178177

179178
parser.add_argument(
180179
"--extra",
181180
action="store_true",
182-
help="Open's the extra directory menu to use more tools. "
183-
f"{cls.colorify('- Still experimental -', 'y')} "
184-
f"{cls.colorify('- MUST have used --unzip-extra flag -', 'b')}.",
181+
help=f"{cls.colorify('[REMOVED]', 'r')} Open's the extra directory menu to use more tools. "
185182
)
186183

187184
return parser.parse_args(), parser
@@ -276,9 +273,15 @@ def data(cls) -> ArgumentParser | tuple[str]:
276273
return tuple(used_flags)
277274

278275
@staticmethod
279-
def show_help_menu():
276+
def show_help_menu(format_output: bool = False):
280277
"""
281278
Displays the help menu for the Logicytics application.
279+
280+
Args:
281+
format_output (bool): If True, returns the help text instead of printing it
282282
"""
283283
_, parser = Flag.__available_arguments()
284-
parser.print_help()
284+
if format_output:
285+
return parser.format_help()
286+
else:
287+
parser.print_help()

README.md

Lines changed: 15 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -32,16 +32,16 @@ To install and setup Logicytics, follow these steps:
3232

3333
2. **Install Dependencies**: Logicytics requires Python modules. You can install all the required modules by running the following command in your terminal: `pip install -r requirements.txt`
3434

35-
3635
3. **Run Logicytics**: To run Logicytics, simply run the following command in your terminal: `python Logicytics.py -h` - This opens a help menu.
3736

3837
> [!IMPORTANT]
3938
> We recommend Python Version `3.11` or higher, as the project is developed and tested on this version.
4039
>
4140
> You must also install `pytorch` if you want to use the vulnscan feature, To install run the command `pip3 install torch torchvision torchaudio --index-url https://download.pytorch.org/whl/cu124`
42-
> If the device has CUDA available (NVidea GPU's),
41+
> If the device has CUDA available (NVidea GPUs),
4342
>
44-
> Otherwise run `pip3 install torch torchvision torchaudio` to use the CPU, ofcourse this is optional for normal usage's,
43+
> Otherwise, run `pip3 install torch torchvision torchaudio` to use the CPU, ofcourse this is optional for normal
44+
> usage's,
4545
> until you require `vulnscan`
4646
4747
### Prerequisites
@@ -124,9 +124,7 @@ It is also used to store and save settings for other programs.
124124
> this is used to later check for corruption or bugs.
125125
> VERSION is the version of the project, used to check and pull for updates.
126126
127-
## 🚀 Advanced Usage 🚀
128-
129-
### Mods
127+
## 🚀 Mods 🚀
130128

131129
Mods are special files that are run with the `--modded` flag.
132130
These files are essentially scripts that are run after the main Logicytics.py script is run
@@ -178,19 +176,19 @@ If those don't work attempt:
178176

179177
Check out the [wiki](https://github.com/DefinetlyNotAI/Logicytics/wiki) for help.
180178

181-
## 📊 Data Analysis 📊
182-
183-
## Data Extraction
179+
## 📊 Data Extraction 📊
184180

185181
Logicytics extracts a wide range of data points on a Windows system.
186182

187183
Here are some of the data points that Logicytics extracts:
188184

189185
> [!IMPORTANT]
190-
> Don't recreate the scripts/ideas below as then it's a waste of time for you, unless the Side-note on the script says otherwise, you can however contribute to the script itself.
186+
> Don't recreate the scripts/ideas below as then it's a waste of time for you,
187+
> unless the Side-note on the script says otherwise, you can however contribute to the script itself.
191188
192189
> [!TIP]
193-
> You can check out future plans [here](PLANS.md), you can contribute these plans if you have no idea's on what to contribute!
190+
> You can check out future plans [here](PLANS.md),
191+
> you can contribute these plans if you have no idea's on what to contribute!
194192
195193
| File Name | About | Important Note |
196194
|--------------------------|----------------------------------------------------------------------------------------------------------------------|--------------------------|
@@ -220,7 +218,8 @@ This is not an exhaustive list,
220218
but it should give you a good idea of what data Logicytics is capable of extracting.
221219

222220
> [!NOTE]
223-
> **Any file with `_` is not counted here, do note they may range from custom libraries to special files/wrappers**
221+
> **Any file with `_` is not counted here,
222+
> do note they may range from custom libraries to special files/wrappers**
224223
225224
### Want to create your own mod?
226225

@@ -231,13 +230,12 @@ Check out the [contributing guidlines](CONTRIBUTING.md) file for more info
231230
If there is a specific piece of data that you would like to see extracted by Logicytics,
232231
please let us know. We are constantly working to improve the project and adding new features.
233232

234-
Other than mods, some prefixed tools are in the `EXTRA` directory,
235-
use the `--extra` flag to traverse these special tools
236-
237233
### Want to create your own mod?
238234

239-
Check out the [contributing guidlines](CONTRIBUTING.md) file for more info, as well as the [wiki guidelines](https://github.com/DefinetlyNotAI/Logicytics/wiki/5-How-to-Contribute) for more info
240-
Tips and tricks of the given modules/API's can be found [here](https://github.com/DefinetlyNotAI/Logicytics/wiki/6-Code-tips-and-tricks) too!
235+
Check out the [contributing guidlines](CONTRIBUTING.md) file for more info,
236+
as well as the [wiki guidelines](https://github.com/DefinetlyNotAI/Logicytics/wiki/5-How-to-Contribute) for more info
237+
Tips and tricks of the given modules/APIs can be
238+
found [here](https://github.com/DefinetlyNotAI/Logicytics/wiki/6-Code-tips-and-tricks) too!
241239

242240
> [!IMPORTANT]
243241
> Always adhere to the [coding standards](https://github.com/DefinetlyNotAI/Logicytics/wiki/7-Advanced-Coding-Standards) of Logicytics!

0 commit comments

Comments
 (0)