Fix rquickjs-sys host build failing when cross-compiling to Android#711
Open
richarddd wants to merge 1 commit into
Open
Fix rquickjs-sys host build failing when cross-compiling to Android#711richarddd wants to merge 1 commit into
richarddd wants to merge 1 commit into
Conversation
richarddd
force-pushed
the
fix/host-bindgen-cross-compile
branch
from
949aa16 to
18b76b3
Compare
…using bundled bindings for the host target
richarddd
force-pushed
the
fix/host-bindgen-cross-compile
branch
from
18b76b3 to
ed632f1
Compare
Collaborator
Author
|
Thanks @deretame for reporting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if available)
#709
Description of changes
When cross-compiling with the
macrofeature, sys gets built for the host too, and ifLIBCLANG_PATHpoints at the cross toolchain (e.g. Android NDK) that host build generates mismatched bindings. This makes the host build reuse the bundled binding when one exists instead of running bindgen, avoiding the mismatch.Checklist