fix: batch H — test mock fidelity and tabId assertions

Co-Authored-By: Claude <noreply@anthropic.com>

Author: DeliciousBuding

internal/client/browser.go

@@ -79,6 +79,9 @@ func (c *Client) NameSession(name string) error {
 
 // Navigate navigates a tab to the given URL via CDP.
 func (c *Client) Navigate(tabID, url string) error {
+	if err := validateURL(url); err != nil {
+		return err
+	}
 	id, err := strconv.Atoi(tabID)
 	if err != nil {
 		return fmt.Errorf("navigate requires numeric tab_id, got %q", tabID)
@@ -89,6 +92,18 @@ func (c *Client) Navigate(tabID, url string) error {
 	return err
 }
 
+var blockedURLSchemes = []string{"file:", "javascript:", "data:", "vbscript:"}
+
+func validateURL(rawURL string) error {
+	lower := strings.ToLower(rawURL)
+	for _, scheme := range blockedURLSchemes {
+		if strings.HasPrefix(lower, scheme) {
+			return fmt.Errorf("blocked URL scheme %q", scheme)
+		}
+	}
+	return nil
+}
+
 // NavigateBack navigates a tab back in history via CDP.
 func (c *Client) NavigateBack(tabID string) error {
 	id, err := strconv.Atoi(tabID)

internal/client/e2e_test.go

@@ -36,9 +36,14 @@ func TestCdpWithAttachSequence(t *testing.T) {
 		t.Run(tt.name, func(t *testing.T) {
 			c, rec, cleanup := withRecordingServer(t, func(req protocol.Request) interface{} {
 				if req.Method == "executeCdp" {
-					return map[string]interface{}{
-						"result": map[string]interface{}{"value": "ok"},
-						"data":   "iVBORw0KGgo...",
+					params, _ := req.Params.(map[string]interface{})
+					switch params["method"] {
+					case "Runtime.evaluate":
+						return map[string]interface{}{"result": map[string]interface{}{"value": "ok"}}
+					case "Page.captureScreenshot":
+						return map[string]interface{}{"data": "iVBORw0KGgo..."}
+					default:
+						return map[string]interface{}{"result": map[string]interface{}{"value": "ok"}}
 					}
 				}
 				return map[string]bool{"ok": true}
@@ -56,9 +61,15 @@ func TestCdpWithAttachSequence(t *testing.T) {
 			if calls[0].method != "detach" {
 				t.Errorf("call[0] = %q, want detach", calls[0].method)
 			}
+			if v, ok := calls[0].params["tabId"].(float64); !ok || v != 1 {
+				t.Errorf("detach tabId = %v, want 1", calls[0].params["tabId"])
+			}
 			if calls[1].method != "attach" {
 				t.Errorf("call[1] = %q, want attach", calls[1].method)
 			}
+			if v, ok := calls[1].params["tabId"].(float64); !ok || v != 1 {
+				t.Errorf("attach tabId = %v, want 1", calls[1].params["tabId"])
+			}
 			if calls[2].method != "executeCdp" {
 				t.Errorf("call[2] = %q, want executeCdp", calls[2].method)
 			}

internal/mcp/handlers_test.go

@@ -291,7 +291,10 @@ func TestHandleScreenshot(t *testing.T) {
 
 func TestHandleEvaluate(t *testing.T) {
 	srv, pipe, cleanup := newServerWithPipe(t, func(req protocol.Request) (interface{}, *protocol.ErrorObject) {
-		return map[string]interface{}{"result": map[string]interface{}{"value": "hello"}}, nil
+		if req.Method == "executeCdp" {
+			return map[string]interface{}{"result": map[string]interface{}{"value": "hello"}}, nil
+		}
+		return map[string]bool{"ok": true}, nil
 	})
 	defer cleanup()
 

internal/mcp/server.go

@@ -136,10 +136,10 @@ func (s *MCPServer) registerTools() {
 			Handler:     s.handleCUAScroll},
 
 		// DOM CUA
-		{Name: "codex_dom_get_visible", Description: "Get visible DOM with node IDs for DOM-based interaction",
+		{Name: "codex_dom_get_visible", Description: "Get a simplified visible DOM tree (human-readable; use codex_dom_snapshot for node IDs usable with codex_dom_click)",
 			InputSchema: schema(`{"type":"object","properties":{"tab_id":{"type":"string"}},"required":["tab_id"]}`),
 			Handler:     s.handleGetVisibleDOM},
-		{Name: "codex_dom_click", Description: "Click a DOM node by its node ID",
+		{Name: "codex_dom_click", Description: "Click a DOM node by its accessibility node ID from codex_dom_snapshot",
 			InputSchema: schema(`{"type":"object","properties":{"tab_id":{"type":"string"},"node_id":{"type":"string"}},"required":["tab_id","node_id"]}`),
 			Handler:     s.handleDomClick},
 
@@ -216,6 +216,8 @@ func (s *MCPServer) handleMessage(req struct {
 		s.writeResult(req.ID, map[string]interface{}{"tools": tools})
 	case "tools/call":
 		s.handleToolCall(req.ID, req.Params)
+	case "ping":
+		s.writeResult(req.ID, map[string]interface{}{})
 	case "notifications/initialized":
 		// Notification — no response per JSON-RPC 2.0 Section 4.1
 	default: