change waituntilfinish to value-task

Author: lucasteles

src/Backdash/Session/Backends/LocalSession.cs

@@ -93,7 +93,7 @@ public void Start(CancellationToken stoppingToken = default)
         backGroundJobTask = tsc.Task.WaitAsync(stoppingToken);
     }
 
-    public async Task WaitUntilFinish(CancellationToken stoppingToken = default)
+    public async ValueTask WaitUntilFinish(CancellationToken stoppingToken = default)
     {
         // ReSharper disable once MethodSupportsCancellation
         tsc.TrySetCanceled(stoppingToken);

src/Backdash/Session/Backends/RemoteSession.cs

@@ -249,13 +249,11 @@ public void Start(CancellationToken stoppingToken = default)
         backgroundJobTask = jobManager.Start(options.UseBackgroundThread, stoppingToken);
     }
 
-    public Task WaitUntilFinish(CancellationToken stoppingToken = default)
+    public async ValueTask WaitUntilFinish(CancellationToken stoppingToken = default)
     {
-        if (!jobManager.IsRunning)
-            return Task.CompletedTask;
-
+        if (!jobManager.IsRunning) return;
         jobManager.Stop(TimeSpan.Zero);
-        return backgroundJobTask.WaitAsync(stoppingToken);
+        await backgroundJobTask.WaitAsync(stoppingToken);
     }
 
     public void BeginFrame()

src/Backdash/Session/Backends/ReplaySession.cs

@@ -162,7 +162,7 @@ public void Start(CancellationToken stoppingToken = default)
         isSynchronizing = false;
     }
 
-    public Task WaitUntilFinish(CancellationToken stoppingToken = default) => Task.CompletedTask;
+    public ValueTask WaitUntilFinish(CancellationToken stoppingToken = default) => ValueTask.CompletedTask;
 
     [MemberNotNull(nameof(callbacks))]
     public void SetHandler(INetcodeSessionHandler handler)

src/Backdash/Session/Backends/SpectatorSession.cs

@@ -235,7 +235,7 @@ public void Start(CancellationToken stoppingToken = default)
         logger.Write(LogLevel.Information, $"Spectating started on host {hostEndpoint}");
     }
 
-    public async Task WaitUntilFinish(CancellationToken stoppingToken = default)
+    public async ValueTask WaitUntilFinish(CancellationToken stoppingToken = default)
     {
         jobManager.Stop(TimeSpan.Zero);
         await backgroundJobTask.WaitAsync(stoppingToken).ConfigureAwait(false);

src/Backdash/Session/Backends/SyncTestSession.cs

@@ -151,7 +151,7 @@ public void Start(CancellationToken stoppingToken = default)
         backGroundJobTask = tsc.Task.WaitAsync(stoppingToken);
     }
 
-    public async Task WaitUntilFinish(CancellationToken stoppingToken = default)
+    public async ValueTask WaitUntilFinish(CancellationToken stoppingToken = default)
     {
         // ReSharper disable once MethodSupportsCancellation
         tsc.SetCanceled(stoppingToken);

src/Backdash/Session/INetcodeSession.cs

@@ -195,7 +195,7 @@ public interface INetcodeSession : INetcodeSessionInfo, IDisposable, IAsyncDispo
     /// <summary>
     ///     Waits for the session background work to finish.
     /// </summary>
-    Task WaitUntilFinish(CancellationToken stoppingToken = default);
+    ValueTask WaitUntilFinish(CancellationToken stoppingToken = default);
 
     /// <summary>
     ///     Set the handler for the current session.