fix: Add support for asymmetric error bars in deltakit.analysis#273
Open
mhmohona wants to merge 1 commit into
Open
fix: Add support for asymmetric error bars in deltakit.analysis#273mhmohona wants to merge 1 commit into
mhmohona wants to merge 1 commit into
Conversation
mhmohona
requested review from
AndrewPattersonRL,
nelimee and
rolandriver
as code owners
|
|
nelimee
added
the
unitaryDESIGN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Closed Issues
Link any issues closed or comments addressed by this PR.
"Closes #X" will close issue X automatically when the PR is merged.
Closes #134
📝 Description
Symmetric vs asymmetric: Gray = old ±3σ Gaussian; teal = binomial likelihood intervals (h=1000). At low rates, symmetric band is too narrow upward and can mislead near zero.
Deltakit plotting API: Data points use logical_error_probabilities_fit; orange line + shaded band = LEPPR fit (still symmetric on ε — known limitation).
Add any additional description required to understand the PR.
Cite related issues, PRs, or comments as needed.
🚦 Status
If anything still needs to be done before this PR can be merged, track it here.
🛠️ Future Work
Focused PRs are good!
Create and link issues for any follow-up work needed.
➕️ Additional Information
Anything that doesn't fit into a category above.
🧾 Release Note
If this PR will be squash-merged, draft the final one-line commit message here.
Otherwise, describe your rebase strategy or how you plan to maintain clean commits.