Skip to content

Commit 5b92778

Browse files
authored
chore(release): name the 2.1 line twinned (#453)
* chore(release): name the 2.1 line twinned The codename had read "navigable" since the 1.9 line and went out unchanged with 2.0. Nothing derives it from the release and no guard covers it — the sibling `version` line got one after the hero drifted to a stale number, but the name beside it did not. "twinned" is the release: one session, two outputs with the same geometry. The file's own comment claimed the release script stamps the banner with both values. It stamps only the version — neither banner renderer reads the codename. It is read by EngineDeckExample alone, whose committed asset nothing regenerates, which is why a stale name survives a release unnoticed. The comment now says that. * test(examples): update the engine-deck layout baseline for the new codename The deck renders the codename as a text node, so renaming the release moves its measured width: "navigable" is 59.92 pt in Helvetica-Oblique at 14 pt, "twinned" is 48.244 pt. Those two values are the whole baseline delta — the tag sits in a fixed-width version block, so nothing downstream shifts.
1 parent 60c1f62 commit 5b92778

2 files changed

Lines changed: 13 additions & 6 deletions

File tree

examples/src/main/resources/banner.properties

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,15 @@
33
# `version` is filled by Maven resource filtering from the reactor
44
# ${project.version} at build time (see examples/pom.xml <resources>), so the
55
# rendered hero is never a hand-bumped literal and can never drift from the
6-
# release it was cut from. `codename` is the per-minor release name, set during
7-
# release prep. cut-release.ps1 re-renders the banner on every tag, stamping the
8-
# committed assets/readme/repository_showcase_render.png with both values.
6+
# release it was cut from. cut-release.ps1 re-renders
7+
# assets/readme/repository_showcase_render.png on every tag so that hero always
8+
# carries the version it was cut from.
9+
#
10+
# `codename` is the per-minor release name and is NOT derived from anything —
11+
# update it by hand during release prep. It is read only by EngineDeckExample
12+
# (title, section header, version block, and the footer on every slide); the
13+
# hero banner renderers do not use it. Nothing regenerates that deck's committed
14+
# asset, so a stale codename survives a release unnoticed — which is how it sat
15+
# on the 1.9 name through 2.0.
916
version=@project.version@
10-
codename=navigable
17+
codename=twinned

examples/src/test/resources/layout-snapshots/flagships/engine-deck.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -895,11 +895,11 @@
895895
"computedY" : 503.938,
896896
"placementX" : 570.0,
897897
"placementY" : 503.938,
898-
"placementWidth" : 59.92,
898+
"placementWidth" : 48.244,
899899
"placementHeight" : 12.95,
900900
"startPage" : 0,
901901
"endPage" : 0,
902-
"contentWidth" : 59.92,
902+
"contentWidth" : 48.244,
903903
"contentHeight" : 12.95,
904904
"margin" : {
905905
"top" : 0.0,

0 commit comments

Comments
 (0)